FreeCalypso > hg > fc-tourmaline
view src/g23m-gprs/gmm/gmm_kerns.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
author | Mychaela Falconia <falcon@freecalypso.org> |
---|---|
date | Mon, 26 Apr 2021 20:55:25 +0000 |
parents | fa8dc04885d8 |
children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GPRS (8441) | Modul : gmm_kerns.h +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Definitions for gmm_kerns.c +----------------------------------------------------------------------------- */ #ifndef GMM_KERNS_H #define GMM_KERNS_H EXTERN void sig_auth_kern_abort_ind ( void ); EXTERN void sig_auth_kern_dereg_ind ( void ); EXTERN void sig_rx_kern_att_acc_ind ( void ); EXTERN void sig_rx_kern_att_rej_ind ( void ); EXTERN void sig_rx_kern_det_req_ind ( void ); EXTERN void sig_rx_kern_det_acc_ind ( void ); EXTERN void sig_rx_kern_rau_acc_ind ( void ); EXTERN void sig_rx_kern_rau_rej_ind ( void ); EXTERN void sig_rx_kern_realloc_cmd_ind ( void ); EXTERN void sig_rx_kern_auth_req_ind ( void ); EXTERN void sig_rx_kern_auth_rej_ind ( void ); EXTERN void sig_rx_kern_id_req_ind ( void ); EXTERN void sig_rx_kern_status_ind ( void ); EXTERN void sig_rx_kern_info_ind ( void ); EXTERN void sig_rx_kern_tst_cmd_ind ( void ); #ifdef GMM_TCS4 #ifdef FF_EGPRS EXTERN void sig_rx_kern_egprs_loopb_cmd_ind ( void ); #endif /*FF_EGPRS*/ #endif /*GMM_TCS4*/ EXTERN void sig_sync_kern_cell_ind ( T_SIG_CELL_INFO * sig_cell_info ); EXTERN void sig_sync_kern_mmgmm_nreg_ind ( T_MMGMM_NREG_IND *mmgmm_nreg_ind ); EXTERN void sig_sync_kern_mmgmm_reg_rej ( T_MMGMM_REG_REJ *mmgmm_reg_rej ); EXTERN void sig_sync_kern_mmgmm_reg_cnf ( T_MMGMM_REG_CNF *mmgmm_reg_cnf ); EXTERN void sig_rdy_kern_cu_ind ( void ); #endif /* !GMM_KERNS_H */