FreeCalypso > hg > fc-tourmaline
view src/cs/riviera/tests/rtest/rtest_msg_i.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 26 Apr 2021 20:55:25 +0000 |
| parents | 4e78acac3d88 |
| children |
line wrap: on
line source
/** * @file rtest_msg_i.h * * Data structures: * 1) Used to send messages to the RTEST SWE, * 2) RTEST can receive. * * Only for internal use. * * @author Vincent Oberle (v-oberle@ti.com) * @version 0.1 */ /* * History: * * Date Author Modification * ------------------------------------------------------------------- * 11/21/2001 Vincent Oberle Create * 03/04/2002 Vincent Oberle Changed name to RTEST * 03/15/2002 Vincent Oberle Put as a internal file, * reduced nb of messages * * (C) Copyright 2002 by Texas Instruments Incorporated, All Rights Reserved */ #ifndef __RTEST_MSG_I_H_ #define __RTEST_MSG_I_H_ #include "rv/rv_general.h" #include "tests/rtest/rtest_api.h" /** * Macro used for tracing RTEST messages. */ #define RTEST_SEND_TRACE(string, trace_level) \ rvf_send_trace (string, (sizeof(string) - 1), NULL_PARAM, trace_level, RTEST_USE_ID) #define RTEST_SEND_TRACE_PARAM(string, param, trace_level) \ rvf_send_trace (string, (sizeof(string) - 1), param, trace_level, RTEST_USE_ID) /** * The message offset must differ for each SWE in order to have * unique msg_id in the system. */ #define RTEST_MESSAGE_OFFSET BUILD_MESSAGE_OFFSET(RTEST_USE_ID) /*************** * to RTEST SWE * ***************/ /** * @name RTEST_START_TEST * * Message to indicate to the Test SWE to proceed * to a test. */ /*@{*/ /** Message ID. */ #define RTEST_START_TEST (RTEST_MESSAGE_OFFSET | 0x001) /** Message structure. */ typedef struct { /** Message header. */ T_RV_HDR hdr; /** * The pointer on the test function. */ T_RTEST_FUNC test_fct; } T_RTEST_START_TEST; /*@}*/ /***************** * from RTEST SWE * *****************/ /** * @name RTEST_TEST_RESULT * * Message issued by the RTEST SWE to indicate the result of a test. */ /*@{*/ /** Message ID. */ #define RTEST_TEST_RESULT (RTEST_MESSAGE_OFFSET | 0x02) /** Message structure. */ typedef struct { /** Message header. */ T_RV_HDR hdr; /** * Test result value. Possible values are: * - TEST_PASSED: No error occured * - TEST_FAILED: An error occured but continue test suite * - TEST_IRRECOVERABLY_FAILED: An error occured, stop test suite */ T_RV_TEST_RET result; } T_RTEST_TEST_RESULT; /*@}*/ #endif /* __RTEST_MSG_I_H_ */