FreeCalypso > hg > fc-tourmaline
view src/condat/com/include/vmd.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 26 Apr 2021 20:55:25 +0000 |
| parents | 4e78acac3d88 |
| children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GSM (6301) | Modul : +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Types definitions for the voice memo and dialling driver | . +----------------------------------------------------------------------------- */ #ifndef DEF_VMD_H #define DEF_VMD_H /* * Signal Types */ #define VMD_END_RECORD 1 #define VMD_END_PLAY 2 #define VMD_SPEECH_RECOGNITION 3 /* * type definitions */ typedef struct vmd_start_record_type { USHORT * start_address; USHORT * stop_address; UBYTE dtx_used; USHORT tone_id; } vmd_start_record_type; typedef struct vmd_start_play_type { USHORT * start_address; } vmd_start_play_type; typedef struct vmd_end_record_type { USHORT * stop_address; } vmd_end_record_type; typedef struct vmd_end_play_type { USHORT * stop_address; } vmd_end_play_type; typedef struct vmd_speech_recognition_req_type { USHORT i_speaker; USHORT i_action; USHORT i_param1; USHORT i_param2; USHORT * address; USHORT total_vocabulary_number; } vmd_speech_recognition_req_type; /* * Constants */ #define SC_SR_MAX_NB_USER 10 #define SC_SR_START_ENROLL 1 #define SC_SR_START_UPDATE 2 #define SC_SR_START_RECO 3 #define SC_SR_ABORT 6 #define SC_SR_START_UPDATE_CHECK 13 #define C_SR_CORRECT_END 0 #define C_SR_CORRECT_END_ACQ 1 #define C_SR_CORRECT_END_UPD 2 #define C_SR_CORRECT_END_RECO 3 #define C_SR_TIME_OUT 11 #define C_SR_BAD_ACQUISITION 12 #define C_SR_OOV_TOOCLOSE 13 #define C_SR_UPDATE_CHECK_ERR 14 #define C_SR_BAD_RECOGNITION 20 #if defined (NEW_FRAME) /* * to achieve backward compatibility with older definitions */ #define drv_SignalCB_Type T_DRV_CB_FUNC #define drv_SignalID_Type T_DRV_SIGNAL #endif /* * Prototypes */ EXTERN UBYTE vmd_init (drv_SignalCB_Type in_SignalCBPtr); EXTERN void vmd_exit (void); EXTERN UBYTE vmd_start_voice_memo_recording (vmd_start_record_type * vmd_parameter); EXTERN UBYTE vmd_stop_voice_memo_recording (void); EXTERN UBYTE vmd_start_voice_memo_playing (vmd_start_play_type * vmd_parameter); EXTERN UBYTE vmd_stop_voice_memo_playing (void); EXTERN UBYTE vmd_start_recognition (vmd_speech_recognition_req_type * vmd_parameter); EXTERN UBYTE vmd_primitive (USHORT opc, void * data); #endif
