FreeCalypso > hg > fc-tourmaline
view src/condat/com/include/kbd.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 26 Apr 2021 20:55:25 +0000 |
| parents | 4e78acac3d88 |
| children |
line wrap: on
line source
/* +----------------------------------------------------------------------------- | Project : GSM (6301) | Modul : +----------------------------------------------------------------------------- | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +----------------------------------------------------------------------------- | Purpose : Types definitions for the keybord driver | . +----------------------------------------------------------------------------- */ #ifndef KBD_H #define KBD_H /* * typematic rates (character per second) */ #define KBD_TYPERATE_NONE 0 #define KBD_TYPERATE_6 1 #define KBD_TYPERATE_8 2 #define KBD_TYPERATE_10 3 #define KBD_TYPERATE_12 4 #define KBD_TYPERATE_15 5 #define KBD_TYPERATE_20 6 #define KBD_TYPERATE_24 7 #define KBD_TYPERATE_30 8 /* * type delay (in milliseconds) */ #define KBD_TYPEDELAY_250 1 #define KBD_TYPEDELAY_500 2 #define KBD_TYPEDELAY_750 3 #define KBD_TYPEDELAY_1000 4 /* * Keyboard operations */ #define KBD_KEYDOWN 1 #define KBD_KEYUP 2 #define KBD_KEYREPEAT 3 /* * Keyboard signals */ #define KBD_SIGTYPE_STATUSCHG 1 /* * Driver Control Block */ typedef struct kbd_DCB_Type { USHORT TypematicRate; USHORT TypematicDelay; } kbd_DCB_Type; #if defined (NEW_FRAME) /* * to achieve backward compatibility with older definitions */ #define drv_SignalCB_Type T_DRV_CB_FUNC #define drv_SignalID_Type T_DRV_SIGNAL #define T_VSI_THANDLE USHORT #endif /* Marcus: Issue 811: 05:09/2002: Start */ /* * Number of elements in the keypad arrays */ #define NUM_KPD_KEYS 32 /* * External data */ extern const UBYTE kbd_map [NUM_KPD_KEYS]; extern const UBYTE simkbd_map [NUM_KPD_KEYS]; extern char * const config_map [NUM_KPD_KEYS]; /* Marcus: Issue 811: 05:09/2002: End */ /* * Prototypes */ EXTERN UBYTE kbd_Init (drv_SignalCB_Type in_SignalCBPtr); EXTERN void kbd_Exit (void); EXTERN UBYTE kbd_SetConfig (kbd_DCB_Type * in_DCBPtr); EXTERN UBYTE kbd_GetConfig (kbd_DCB_Type * out_DCBPtr); EXTERN UBYTE kbd_SetSignal (drv_SignalID_Type * in_SignalIDPtr); EXTERN UBYTE kbd_ResetSignal (drv_SignalID_Type * in_SignalIDPtr); EXTERN ULONG kbd_GetStatus (void); #endif
