FreeCalypso > hg > fc-tourmaline
view cdg-hybrid/cdginc/p_rlp.val @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 26 Apr 2021 20:55:25 +0000 |
| parents | 35f7a1dc9f7d |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_rlp.val | | SOURCE : "sap\rlp.pdf" | | LastModified : "2002-04-22" | | IdAndVersion : "8411.101.98.115" | | SrcFileTime : "Thu Nov 29 09:51:48 2007" | | Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_RLP_VAL #define P_RLP_VAL #define CDG_ENTER__P_RLP_VAL #define CDG_ENTER__FILENAME _P_RLP_VAL #define CDG_ENTER__P_RLP_VAL__FILE_TYPE CDGINC #define CDG_ENTER__P_RLP_VAL__LAST_MODIFIED _2002_04_22 #define CDG_ENTER__P_RLP_VAL__ID_AND_VERSION _8411_101_98_115 #define CDG_ENTER__P_RLP_VAL__SRC_FILE_TIME _Thu_Nov_29_09_51_48_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_RLP_VAL #undef CDG_ENTER__FILENAME /* * Value constants for VAL_pt */ #define RLP_COMPR_TYPE_V42BIS (0x0) /* V.42bis */ /* * Value constants for VAL_p0 */ #define RLP_COMP_DIR_NONE (0x0) /* compress in neither direction */ #define RLP_COMP_DIR_TRANSMIT (0x1) /* compress in uplink direction only */ #define RLP_COMP_DIR_RECEIVE (0x2) /* compress in downlink direction only */ #define RLP_COMP_DIR_BOTH (0x3) /* compress in both directions */ /* * Value constants for VAL_rate */ #define RLP_HALFRATE_4800 (0x0) /* halfrate 4,8/6 kBit */ #define RLP_FULLRATE_4800 (0x1) /* fullrate 4,8/6 kBit */ #define RLP_FULLRATE_9600 (0x2) /* fullrate 9,6/12 kBit */ #define RLP_FULLRATE_14400 (0x3) /* fullrate 13,4/14,4 kBit */ /* * Value constants for VAL_ack_flg */ #define RLP_ACK (0x0) /* acknowledged */ #define RLP_NAK (0x1) /* not acknowledged */ /* * Value constants for VAL_cause */ #define RLP_ERR_PF_RETRANS (0xc200) /* Max Retransmissions of Poll reached */ #define RLP_ERR_XID_RETRANS (0xc201) /* Max Retransmissions of XID reached */ #define RLP_ERR_SABM_RETRANS (0xc202) /* Max Retransmissions of SABM reached */ #define RLP_ERR_DISC_RETRANS (0xc203) /* Max Retransmissions of DISC reached */ #define RLP_ERR_REMAP_RETRANS (0xc204) /* Max Retransmissions of REMAP reached */ #define RLP_ERR_SDU_TO_SMALL (0xc210) /* Received SDU is to small */ #define RLP_ERR_INTERNAL (0xc220) /* Internal error */ /* * user defined constants */ #define RLP_HEADER_LEN (0x10) #define RLP_TRAILER_LEN (0x0) #include "CDG_LEAVE.h" #endif
