FreeCalypso > hg > fc-tourmaline
view cdg-hybrid/cdginc/p_l1test.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 26 Apr 2021 20:55:25 +0000 |
| parents | 35f7a1dc9f7d |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_l1test.h | | SOURCE : "sap\l1test.pdf" | | LastModified : "2003-06-06" | | IdAndVersion : "8010.148.03.003" | | SrcFileTime : "Thu Nov 29 09:44:08 2007" | | Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : L1TEST * COMPATIBILITY_DEFINES : NO * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_L1TEST_H #define P_L1TEST_H #define CDG_ENTER__P_L1TEST_H #define CDG_ENTER__FILENAME _P_L1TEST_H #define CDG_ENTER__P_L1TEST_H__FILE_TYPE CDGINC #define CDG_ENTER__P_L1TEST_H__LAST_MODIFIED _2003_06_06 #define CDG_ENTER__P_L1TEST_H__ID_AND_VERSION _8010_148_03_003 #define CDG_ENTER__P_L1TEST_H__SRC_FILE_TIME _Thu_Nov_29_09_44_08_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_L1TEST_H #undef CDG_ENTER__FILENAME #include "p_l1test.val" #include "p_mphc.h" #include "p_mac.h" /* * End of substructure section, begin of primitive definition section */ #ifndef __T_L1TEST_CALL_MPHC_READ_DCCH__ #define __T_L1TEST_CALL_MPHC_READ_DCCH__ /* * * CCDGEN:WriteStruct_Count==1679 */ typedef struct { U8 chn_mode; /*< 0: 1> Channel mode */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ } T_L1TEST_CALL_MPHC_READ_DCCH; #endif #ifndef __T_L1TEST_RETURN_MPHC_READ_DCCH__ #define __T_L1TEST_RETURN_MPHC_READ_DCCH__ /* * * CCDGEN:WriteStruct_Count==1680 */ typedef struct { T_l2_frame l2_frame; /*< 0: 24> layer 2 frame (type defined in "p_mphc.h") */ } T_L1TEST_RETURN_MPHC_READ_DCCH; #endif #ifndef __T_L1TEST_CALL_MPHC_DCCH_DOWNLINK__ #define __T_L1TEST_CALL_MPHC_DCCH_DOWNLINK__ /* * * CCDGEN:WriteStruct_Count==1681 */ typedef struct { T_l2_frame l2_frame; /*< 0: 24> layer 2 frame (type defined in "p_mphc.h") */ U8 valid_flag; /*< 24: 1> Valid flag for received data */ U8 _align0; /*< 25: 1> alignment */ U8 _align1; /*< 26: 1> alignment */ U8 _align2; /*< 27: 1> alignment */ } T_L1TEST_CALL_MPHC_DCCH_DOWNLINK; #endif #ifndef __T_L1TEST_RETURN_MPHC_DCCH_DOWNLINK__ #define __T_L1TEST_RETURN_MPHC_DCCH_DOWNLINK__ /* * * CCDGEN:WriteStruct_Count==1682 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_L1TEST_RETURN_MPHC_DCCH_DOWNLINK; #endif #ifndef __T_L1TEST_CALL_MPHC_DATA_UL__ #define __T_L1TEST_CALL_MPHC_DATA_UL__ /* * * CCDGEN:WriteStruct_Count==1683 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_L1TEST_CALL_MPHC_DATA_UL; #endif #ifndef __T_L1TEST_RETURN_MPHC_DATA_UL__ #define __T_L1TEST_RETURN_MPHC_DATA_UL__ /* * * CCDGEN:WriteStruct_Count==1684 */ typedef struct { T_l2_frame l2_frame; /*< 0: 24> layer 2 frame (type defined in "p_mphc.h") */ U16 d_ra_conf; /*< 24: 2> Traffic control register */ U16 d_ra_act; /*< 26: 2> Activity word */ U16 d_ra_statu; /*< 28: 2> Rate adaptation status word for uplink */ U16 d_fax; /*< 30: 2> Fax status and parameter word */ } T_L1TEST_RETURN_MPHC_DATA_UL; #endif #ifndef __T_L1TEST_CALL_MPHC_DATA_DL__ #define __T_L1TEST_CALL_MPHC_DATA_DL__ /* * * CCDGEN:WriteStruct_Count==1685 */ typedef struct { T_l2_frame l2_frame; /*< 0: 24> layer 2 frame (type defined in "p_mphc.h") */ U16 d_ra_act; /*< 24: 2> Activity word */ U16 d_ra_statd; /*< 26: 2> Rate adaptation status word for downlink */ } T_L1TEST_CALL_MPHC_DATA_DL; #endif #ifndef __T_L1TEST_RETURN_MPHC_DATA_DL__ #define __T_L1TEST_RETURN_MPHC_DATA_DL__ /* * * CCDGEN:WriteStruct_Count==1686 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_L1TEST_RETURN_MPHC_DATA_DL; #endif #ifndef __T_L1TEST_CALL_MPHP_POWER_CONTROL__ #define __T_L1TEST_CALL_MPHP_POWER_CONTROL__ /* * * CCDGEN:WriteStruct_Count==1687 */ typedef struct { U8 assignment_id; /*< 0: 1> Assignment Id */ U8 crc_error; /*< 1: 1> CRC error */ S8 bcch_level; /*< 2: 1> BCCH level */ U8 _align0; /*< 3: 1> alignment */ U16 radio_freq[L1TEST_BURST_PER_BLOCK]; /*< 4: 8> Radio frequency */ S8 burst_level[L1TEST_BURST_PER_BLOCK]; /*< 12: 4> Burst level */ } T_L1TEST_CALL_MPHP_POWER_CONTROL; #endif #ifndef __T_L1TEST_RETURN_MPHP_POWER_CONTROL__ #define __T_L1TEST_RETURN_MPHP_POWER_CONTROL__ /* * * CCDGEN:WriteStruct_Count==1688 */ typedef struct { U8 pch[L1TEST_MAX_TIMESLOTS]; /*< 0: 8> PCH */ } T_L1TEST_RETURN_MPHP_POWER_CONTROL; #endif #ifndef __T_L1TEST_CALL_MPHP_UPLINK__ #define __T_L1TEST_CALL_MPHP_UPLINK__ /* * * CCDGEN:WriteStruct_Count==1689 */ typedef struct { U8 assignment_id; /*< 0: 1> Assignment Id */ U8 tx_data_no; /*< 1: 1> Tx data number */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ U32 fn; /*< 4: 4> Frame number */ U8 timing_advance_value; /*< 8: 1> Timing advance value */ U8 allocation_exhausted; /*< 9: 1> Allocation exhausted */ U8 _align2; /*< 10: 1> alignment */ U8 _align3; /*< 11: 1> alignment */ } T_L1TEST_CALL_MPHP_UPLINK; #endif #ifndef __T_L1TEST_RETURN_MPHP_UPLINK__ #define __T_L1TEST_RETURN_MPHP_UPLINK__ /* * * CCDGEN:WriteStruct_Count==1690 */ typedef struct { T_ul_poll_resp ul_poll_resp[4]; /*< 0:128> Uplink Poll Response (type defined in "p_mac.h") */ T_ul_data ul_data[4]; /*<128:240> Uplink Data (type defined in "p_mac.h") */ } T_L1TEST_RETURN_MPHP_UPLINK; #endif #ifndef __T_L1TEST_CALL_MPHP_DOWNLINK__ #define __T_L1TEST_CALL_MPHP_DOWNLINK__ /* * * CCDGEN:WriteStruct_Count==1691 */ typedef struct { U8 assignment_id; /*< 0: 1> Assignment Id */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ U32 fn; /*< 4: 4> Frame number */ U8 _align3; /*< 8: 1> alignment */ U8 _align4; /*< 9: 1> alignment */ U8 _align5; /*< 10: 1> alignment */ U8 c_dl_data; /*< 11: 1> counter */ T_dl_data dl_data[4]; /*< 12:256> Downlink Data (type defined in "p_mac.h") */ U8 rlc_blocks_sent; /*<268: 1> RLC blocks sent */ U8 last_poll_response; /*<269: 1> Last poll response */ U8 _align6; /*<270: 1> alignment */ U8 _align7; /*<271: 1> alignment */ } T_L1TEST_CALL_MPHP_DOWNLINK; #endif #ifndef __T_L1TEST_RETURN_MPHP_DOWNLINK__ #define __T_L1TEST_RETURN_MPHP_DOWNLINK__ /* * * CCDGEN:WriteStruct_Count==1692 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_L1TEST_RETURN_MPHP_DOWNLINK; #endif #include "CDG_LEAVE.h" #endif