FreeCalypso > hg > fc-tourmaline
view cdg-hybrid/cdginc/p_dti.h @ 220:0ed36de51973
ABB semaphore protection overhaul
The ABB semaphone protection logic that came with TCS211 from TI
was broken in several ways:
* Some semaphore-protected functions were called from Application_Initialize()
context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with
NU_INVALID_SUSPEND in this context, but the return value wasn't checked,
and NU_Release_Semaphore() would be called unconditionally at the end.
The latter call would increment the semaphore count past 1, making the
semaphore no longer binary and thus no longer effective for resource
protection. The fix is to check the return value from NU_Obtain_Semaphore()
and skip the NU_Release_Semaphore() call if the semaphore wasn't properly
obtained.
* Some SPI hardware manipulation was being done before entering the semaphore-
protected critical section. The fix is to reorder the code: first obtain
the semaphore, then do everything else.
* In the corner case of L1/DSP recovery, l1_abb_power_on() would call some
non-semaphore-protected ABB & SPI init functions. The fix is to skip those
calls in the case of recovery.
* A few additional corner cases existed, all of which are fixed by making
ABB semaphore protection 100% consistent for all ABB functions and code paths.
There is still one remaining problem of priority inversion: suppose a low-
priority task calls an ABB function, and some medium-priority task just happens
to preempt right in the middle of that semaphore-protected ABB operation. Then
the high-priority SPI task is locked out for a non-deterministic time until
that medium-priority task finishes its work and goes back to sleep. This
priority inversion problem remains outstanding for now.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Mon, 26 Apr 2021 20:55:25 +0000 |
| parents | 35f7a1dc9f7d |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_dti.h | | SOURCE : "sap\dti.pdf" | | LastModified : "2000-06-29" | | IdAndVersion : "8411.110.00.007" | | SrcFileTime : "Thu Nov 29 09:40:22 2007" | | Generated by CCDGEN_2.5.5A on Fri Oct 14 21:41:52 2016 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_DTI_H #define P_DTI_H #define CDG_ENTER__P_DTI_H #define CDG_ENTER__FILENAME _P_DTI_H #define CDG_ENTER__P_DTI_H__FILE_TYPE CDGINC #define CDG_ENTER__P_DTI_H__LAST_MODIFIED _2000_06_29 #define CDG_ENTER__P_DTI_H__ID_AND_VERSION _8411_110_00_007 #define CDG_ENTER__P_DTI_H__SRC_FILE_TIME _Thu_Nov_29_09_40_22_2007 #include "CDG_ENTER.h" #undef CDG_ENTER__P_DTI_H #undef CDG_ENTER__FILENAME #include "p_dti.val" /* * End of substructure section, begin of primitive definition section */ #ifndef __T_DTI_READY_IND__ #define __T_DTI_READY_IND__ /* * * CCDGEN:WriteStruct_Count==1454 */ typedef struct { U16 tui; /*< 0: 2> transmission unit identifier */ U8 c_id; /*< 2: 1> channel identifier */ U8 op_ack; /*< 3: 1> operation mode */ } T_DTI_READY_IND; #endif #ifndef __T_DTI_GETDATA_REQ__ #define __T_DTI_GETDATA_REQ__ /* * * CCDGEN:WriteStruct_Count==1455 */ typedef struct { U16 tui; /*< 0: 2> transmission unit identifier */ U8 c_id; /*< 2: 1> channel identifier */ U8 op_ack; /*< 3: 1> operation mode */ } T_DTI_GETDATA_REQ; #endif #ifndef __T_DTI_DATA_REQ__ #define __T_DTI_DATA_REQ__ /* * * CCDGEN:WriteStruct_Count==1456 */ typedef struct { U16 tui; /*< 0: 2> transmission unit identifier */ U8 c_id; /*< 2: 1> channel identifier */ U8 p_id; /*< 3: 1> protocol identifier */ U8 op_ack; /*< 4: 1> operation mode */ U8 st_flow; /*< 5: 1> flow control state */ U8 st_line_sa; /*< 6: 1> line state sa */ U8 st_line_sb; /*< 7: 1> line state sb */ U8 st_escape; /*< 8: 1> escape state */ U8 _align0; /*< 9: 1> alignment */ U8 _align1; /*< 10: 1> alignment */ U8 _align2; /*< 11: 1> alignment */ T_desc_list desc_list; /*< 12: ? > list of generic data descriptors */ } T_DTI_DATA_REQ; #endif #ifndef __T_DTI_DATA_IND__ #define __T_DTI_DATA_IND__ /* * * CCDGEN:WriteStruct_Count==1457 */ typedef struct { U16 tui; /*< 0: 2> transmission unit identifier */ U8 c_id; /*< 2: 1> channel identifier */ U8 p_id; /*< 3: 1> protocol identifier */ U8 op_ack; /*< 4: 1> operation mode */ U8 st_flow; /*< 5: 1> flow control state */ U8 st_line_sa; /*< 6: 1> line state sa */ U8 st_line_sb; /*< 7: 1> line state sb */ U8 st_escape; /*< 8: 1> escape state */ U8 _align0; /*< 9: 1> alignment */ U8 _align1; /*< 10: 1> alignment */ U8 _align2; /*< 11: 1> alignment */ T_desc_list desc_list; /*< 12: ? > list of generic data descriptors */ } T_DTI_DATA_IND; #endif #ifndef __T_DTI_DATA_TEST_REQ__ #define __T_DTI_DATA_TEST_REQ__ /* * * CCDGEN:WriteStruct_Count==1458 */ typedef struct { U16 tui; /*< 0: 2> transmission unit identifier */ U8 c_id; /*< 2: 1> channel identifier */ U8 p_id; /*< 3: 1> protocol identifier */ U8 op_ack; /*< 4: 1> operation mode */ U8 st_flow; /*< 5: 1> flow control state */ U8 st_line_sa; /*< 6: 1> line state sa */ U8 st_line_sb; /*< 7: 1> line state sb */ U8 st_escape; /*< 8: 1> escape state */ U8 _align0; /*< 9: 1> alignment */ U8 _align1; /*< 10: 1> alignment */ U8 _align2; /*< 11: 1> alignment */ T_sdu sdu; /*< 12: ? > test data */ } T_DTI_DATA_TEST_REQ; #endif #ifndef __T_DTI_DATA_TEST_IND__ #define __T_DTI_DATA_TEST_IND__ /* * * CCDGEN:WriteStruct_Count==1459 */ typedef struct { U16 tui; /*< 0: 2> transmission unit identifier */ U8 c_id; /*< 2: 1> channel identifier */ U8 p_id; /*< 3: 1> protocol identifier */ U8 op_ack; /*< 4: 1> operation mode */ U8 st_flow; /*< 5: 1> flow control state */ U8 st_line_sa; /*< 6: 1> line state sa */ U8 st_line_sb; /*< 7: 1> line state sb */ U8 st_escape; /*< 8: 1> escape state */ U8 _align0; /*< 9: 1> alignment */ U8 _align1; /*< 10: 1> alignment */ U8 _align2; /*< 11: 1> alignment */ T_sdu sdu; /*< 12: ? > test data */ } T_DTI_DATA_TEST_IND; #endif #ifndef __T_DTI_DUMMY_REQ__ #define __T_DTI_DUMMY_REQ__ /* * * CCDGEN:WriteStruct_Count==1460 */ typedef struct { T_desc desc; /*< 0: ? > generic data descriptor */ } T_DTI_DUMMY_REQ; #endif #include "CDG_LEAVE.h" #endif