comparison src/cs/layer1/cfile/l1_init.c @ 220:0ed36de51973

ABB semaphore protection overhaul The ABB semaphone protection logic that came with TCS211 from TI was broken in several ways: * Some semaphore-protected functions were called from Application_Initialize() context. NU_Obtain_Semaphore() called with NU_SUSPEND fails with NU_INVALID_SUSPEND in this context, but the return value wasn't checked, and NU_Release_Semaphore() would be called unconditionally at the end. The latter call would increment the semaphore count past 1, making the semaphore no longer binary and thus no longer effective for resource protection. The fix is to check the return value from NU_Obtain_Semaphore() and skip the NU_Release_Semaphore() call if the semaphore wasn't properly obtained. * Some SPI hardware manipulation was being done before entering the semaphore- protected critical section. The fix is to reorder the code: first obtain the semaphore, then do everything else. * In the corner case of L1/DSP recovery, l1_abb_power_on() would call some non-semaphore-protected ABB & SPI init functions. The fix is to skip those calls in the case of recovery. * A few additional corner cases existed, all of which are fixed by making ABB semaphore protection 100% consistent for all ABB functions and code paths. There is still one remaining problem of priority inversion: suppose a low- priority task calls an ABB function, and some medium-priority task just happens to preempt right in the middle of that semaphore-protected ABB operation. Then the high-priority SPI task is locked out for a non-deterministic time until that medium-priority task finishes its work and goes back to sleep. This priority inversion problem remains outstanding for now.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 26 Apr 2021 20:55:25 +0000
parents 4e78acac3d88
children edcb8364d45b
comparison
equal deleted inserted replaced
219:d00662aa64d8 220:0ed36de51973
720 Abb->DevId = ABB; 720 Abb->DevId = ABB;
721 Abb->ClkEdge = SPI_CLK_EDG_RISE; 721 Abb->ClkEdge = SPI_CLK_EDG_RISE;
722 Abb->TspEnLevel = SPI_NTSPEN_NEG_LEV; 722 Abb->TspEnLevel = SPI_NTSPEN_NEG_LEV;
723 Abb->TspEnForm = SPI_NTSPEN_LEV_TRIG; 723 Abb->TspEnForm = SPI_NTSPEN_LEV_TRIG;
724 724
725 SPI_InitDev(Abb); /* Initialize the spi to work with ABB */ 725 /*
726 726 * FreeCalypso change: skip the following two non-semaphore-protected
727 ABB_free_13M(); /* Set up Abb connection (CLK 13M free).*/ 727 * steps in the case of L1/DSP recovery, and limit our ABB poking to
728 Abb_Status = ABB_Read_Status(); /* Aknowledge the Abb status register. */ 728 * semaphore-protected functions.
729 */
730 if (l1a_l1s_com.recovery_flag == FALSE)
731 {
732 SPI_InitDev(Abb); /* Initialize the spi to work with ABB */
733 ABB_free_13M(); /* Set up Abb connection (CLK 13M free).*/
734 }
735
736 Abb_Status = ABB_Read_Status(); /* Aknowledge the Abb status register. */
729 737
730 /*------------------------------------------------------------------*/ 738 /*------------------------------------------------------------------*/
731 /* Add here SW to manage Abb VRPCSTS status register informations */ 739 /* Add here SW to manage Abb VRPCSTS status register informations */
732 /*------------------------------------------------------------------*/ 740 /*------------------------------------------------------------------*/
733 741