# HG changeset patch
# User Mychaela Falconia <falcon@freecalypso.org>
# Date 1532239489 0
# Node ID 1ed9de6c90bd0bc0f890a36e85523c1fb7869ffe
# Parent  f2ebef402db8a9a4813495e297efb8f7f6aea386
src/g23m-gsm/sms/sms_for.c: bogus malloc removed

The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:

1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.

This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.

Because the memory allocation in question is not needed at all,
the fix entails simply removing it.

diff -r f2ebef402db8 -r 1ed9de6c90bd src/g23m-gsm/sms/sms_for.c
--- a/src/g23m-gsm/sms/sms_for.c	Fri Jun 29 05:09:01 2018 +0000
+++ b/src/g23m-gsm/sms/sms_for.c	Sun Jul 22 06:04:49 2018 +0000
@@ -213,14 +213,6 @@
   BOOL rp_error_send = FALSE;
 
 
-  ccd_err_entry = malloc(sizeof(T_CCD_ERR_ENTRY));
-  if(ccd_err_entry EQ NULL)
-  {
-     TRACE_EVENT("for_ccd_error_check(): MALLOC returned NULL");
-     return FALSE;
-  }
-  memset(ccd_err_entry,0, sizeof(ccd_err_entry));
-
   /* Message offset value */
   p_sdu = (buf_sdu->o_buf/8) - 1;