FreeCalypso > hg > fc-magnetite
view src/gpf3/ccd/critical_ext.c @ 660:293c7db5f10f
bmi3: fixed the mysterious "mute on first call" bug
When UI-enabled fw boots on a previously blank (no /mmi/* files) FFS
for the first time, the output_volume member of the persistent UI settings
structure was left uninitialized, corresponding to the earpiece volume
being set to mute, which is an invalid setting. Because of other quirks
in the far-from-finished UI code, this volume setting takes effect only
when the first call is answered, producing the odd behaviour seen at the
user level.
The current fix is to set the blank-FFS default for output_volume to
volume level 4, which is the same -6 dB Iota volume as the ACI default.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Thu, 14 May 2020 02:50:41 +0000 |
| parents | c41a534f33c6 |
| children |
line wrap: on
line source
/* +------------------------------------------------------------------------------ | File: critical_ext.c +------------------------------------------------------------------------------ | Copyright 2002 Texas Instruments Berlin, AG | All rights reserved. | | This file is confidential and a trade secret of Texas | Instruments Berlin, AG. | The receipt of or possession of this file does not convey | any rights to reproduce or disclose its contents or to | manufacture, use, or sell anything it may describe, in | whole, or in part, without the specific written consent of | Texas Instruments Berlin, AG. +------------------------------------------------------------------------------ | Purpose: Encoding and decoding functions for criticalExtensions | | $Identity:$ +------------------------------------------------------------------------------ */ /* * Standard definitions like UCHAR, ERROR etc. */ #include "typedefs.h" #include "header.h" /* * Prototypes of ccd (USE_DRIVER EQ undef) for prototypes only * look at ccdapi.h */ #undef USE_DRIVER #include "ccdapi.h" /* * Types and functions for bit access and manipulation */ #include "ccd_globs.h" #include "bitfun.h" /* * Prototypes and constants in the common part of ccd */ #include "ccd.h" /* * Declaration of coder/decoder tables */ #include "ccdtable.h" #include "ccddata.h" #ifndef RUN_INT_RAM /* +------------------------------------------------------------------------+ | PROJECT : CCD (6144) MODULE : critical_ext | | STATE : code ROUTINE : cdc_critical_ext_decode | +------------------------------------------------------------------------+ PURPOSE : Decode elements of type criticalExtensions An element of this type should never be encoded or decoded. If the coder faces an IE of this type, it should report an error report and abort. Whenever a criticalExtensions-IE is extended from NULL or SEQUENCE {} to another type, its CCD coding type will change and the functions in this file will not be called for that IE any more. According to 3GPP TS25.331 V3.6.0, 10.1.1.2.2: Since messages including critical extensions are rejected by receivers not comprehending them, these messages can be modified completely, e.g. IEs may be inserted at any place and IEs may be removed or redefined. See also 3GPP TS25.921 V4.3.0, 10.4. */ SHORT cdc_critical_ext_decode (const ULONG c_ref, const ULONG e_ref, T_CCD_Globs *globs) { #ifdef DEBUG_CCD #ifndef CCD_SYMBOLS TRACE_CCD (globs, "cdc_critical_ext_decode()"); #else TRACE_CCD (globs, "cdc_critical_ext_decode() %s", mcomp[melem[e_ref].elemRef].name); #endif #endif globs->pstructOffs = melem[e_ref].structOffs; /* For optional elements we have already set the valid flag in the * C-structure. We have done it while processing ASN1_SEQ. */ if ( ! cdc_isPresent(e_ref, globs) ) { return 1; } if (melem[e_ref].elemType EQ 'V' AND mvar[melem[e_ref].elemRef].bSize EQ 0) { ccd_recordFault (globs, ERR_CRITICAL_EXT, BREAK, (USHORT) e_ref, globs->pstruct + melem[e_ref].structOffs ); return 0; } /* * Currently CCD tool chain does not support extensions of this type. * This else-implementation is just an outlook. * else { U16 compRef = melem[e_ref].elemRef; U16 elemRef = mcomp[compRef].componentRef; (void) codec[melem[Elem].codingType][DECODE_FUN] (compRef, elemRef, globs); }*/ return 1; } #endif /* !RUN_INT_RAM */ #ifndef RUN_INT_RAM /* +------------------------------------------------------------------------+ | PROJECT : CCD (6144) MODULE : critical_ext | | STATE : code ROUTINE : cdc_critical_ext_encode | +------------------------------------------------------------------------+ PURPOSE : Encode elements of type criticalExtensions An element of this type should never be encoded or decoded. If the coder faces an IE of this type, it should report an error report and abort. */ SHORT cdc_critical_ext_encode (const ULONG c_ref, const ULONG e_ref, T_CCD_Globs *globs) { #ifdef DEBUG_CCD #ifndef CCD_SYMBOLS TRACE_CCD (globs, "cdc_critical_ext_encode()"); #else TRACE_CCD (globs, "cdc_critical_ext_encode() %s", mcomp[melem[e_ref].elemRef].name); #endif #endif globs->pstructOffs = melem[e_ref].structOffs; /* For optional elements we have already set the valid flag in the * C-structure. We have done it while processing ASN1_SEQ. */ if ( ! cdc_isPresent(e_ref, globs) ) { return 1; } if (melem[e_ref].elemType EQ 'V' AND mvar[melem[e_ref].elemRef].bSize EQ 0) { ccd_recordFault (globs, ERR_CRITICAL_EXT, BREAK, (USHORT) e_ref, globs->pstruct + melem[e_ref].structOffs ); return 0; } /* * Currently CCD tool chain does not support extensions of this type. * This else-implementation is just an outlook. * else { U16 compRef = melem[e_ref].elemRef; U16 elemRef = mcomp[compRef].componentRef; (void) codec[melem[Elem].codingType][ENCODE_FUN] (compRef, elemRef, globs); }*/ return 1; } #endif /* !RUN_INT_RAM */
