FreeCalypso > hg > fc-magnetite

view src/ui3/bmi/mmiBtipsGlobal.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents e8ddbb0837ed
children
line wrap: on
line source

#ifndef _MMIBTIPSGLOBAL_H_
#define _MMIBTIPSGLOBAL_H_

/* =========================================================
*             Texas Instruments OMAP(TM) Platform Software
*  (c) Copyright Texas Instruments, Incorporated.  All Rights Reserved.
*
*  Use of this software is controlled by the terms and conditions found
*  in the license agreement under which this software has been supplied.
* ========================================================== */
/*
 $Project name: Basic Bluetooth MMI
 $Project code:
 $Module:   Bluetooth BMG APPlication
 $File:       MmiBtipsBmg.h
 $Revision:   1.0
 $Author:   Texas Instruments
 $Date:       26/06/07

********************************************************************************

 Description:

    This module provides the BTIPS BMG APPlication functionality.

********************************************************************************
 $History: MmiBtipsBmg.h

  26/06/07 Sasken original version

 $End

*******************************************************************************/
/*******************************************************************************
                                                                              
                                Public methods
                                                                              
*******************************************************************************/
USHORT	mmi_btipsRadioOnStatus(struct MfwMnuTag *m, 
									   struct MfwMnuAttrTag *ma, 
									   struct MfwMnuItemTag *mi);
USHORT	mmi_btipsRadioOffStatus(struct MfwMnuTag *m, 
									   struct MfwMnuAttrTag *ma, 
									   struct MfwMnuItemTag *mi);
 int  mmi_btipsRadioOn(MfwMnu* m, MfwMnuItem* i);
GLOBAL int  mmi_btipsRadioOff(void);
int mmi_btips_bmgDevices(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_bmgPhoneName(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_bmgSetVisibility(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_bmgConnectedDevices(MfwMnu* m,MfwMnuItem* i);
int mmi_btips_bmgHidePhone(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_bmgShowPhone(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_bmgSetConnectPermissionAllow(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_bmgSetConnectPermissionAsk(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_bmgDeviceDelete(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_bmgDeviceDisconnect(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_bmgDeviceSetRemotename(MfwMnu* m, MfwMnuItem* i);
USHORT mmi_btips_bmgIsVisible( struct MfwMnuTag *m, struct MfwMnuAttrTag *ma, struct MfwMnuItemTag *mi );
USHORT mmi_btips_bmgIsInvisible( struct MfwMnuTag *m, struct MfwMnuAttrTag *ma, struct MfwMnuItemTag *mi );
int mmi_btips_vgIncomingCallInHandsfree(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_vgIncomingCallInPhone(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_vgMyHandsfree(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_VgConnect(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_vgIsDeviceConnected (struct MfwMnuTag *m, struct MfwMnuAttrTag *ma, struct MfwMnuItemTag *mi);
int mmi_btips_VgDisconnect(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_vgIsDeviceDisconnected (struct MfwMnuTag *m, struct MfwMnuAttrTag *ma, struct MfwMnuItemTag *mi);
int  mmi_btips_a2dpHandler(MfwMnu* m, MfwMnuItem* i);
int  mmi_btips_oppcHandler(MfwMnu* m, MfwMnuItem* i);
int  mmi_btips_oppcPullHandler(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_oppcExchangeHandler(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_a2dpPlayOnSingleDevice(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_a2dpPlayOnMultipleDevice(MfwMnu* m, MfwMnuItem* i);
GLOBAL int mmi_btips_services(MfwMnu* m, MfwMnuItem* i);
int mmi_btips_a2dpDeviceSearchWnd();
USHORT	mmi_Btips_is_audio_on_phone (struct MfwMnuTag *m, struct MfwMnuAttrTag *ma, 
					  struct MfwMnuItemTag *mi);
USHORT	mmi_Btips_is_audio_on_handsfree (struct MfwMnuTag *m, struct MfwMnuAttrTag *ma, 
					  struct MfwMnuItemTag *mi);
USHORT	mmi_Btips_is_audio_handover_possible (struct MfwMnuTag *m, struct MfwMnuAttrTag *ma, 
					  struct MfwMnuItemTag *mi);
int mmi_BtipsTransferAudioToPhone (MfwMnu* m, MfwMnuItem* i);
int mmi_BtipsTransferAudioToHF (MfwMnu* m, MfwMnuItem* i);
int mmi_BtipsAudioHandOver (MfwMnu* m, MfwMnuItem* i);
int mmi_BtipsMyHandsfree(MfwMnu* m, MfwMnuItem* i);
#endif //_MMIBTIPSGLOBAL_H_