FreeCalypso > hg > fc-magnetite

view src/cs/system/bootloader/inc/protocol.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/******************************************************************************
 * FLUID (Flash Loader Utility Independent of Device)
 *
 * (C) Delta Technologies 2001.
 * Cleanup, modifications and extensions by Mads Meisner-Jensen, mmj@ti.com.
 *
 * Target/PC protocol definition
 *
 * $Id: protocol.h 1.9 Wed, 31 Oct 2001 11:47:00 +0100 mmj $
 *
 ******************************************************************************/


enum ProtocolChars {
    PROTO_HELLO         = 'H',
    PROTO_BAUDRATE      = 'B',
    PROTO_HARDWARE      = 'H',
    PROTO_QUERY         = 'Q',
    PROTO_QUERY_CHIP    = 'C',
    PROTO_READY         = 'R',
    PROTO_ISEMPTY       = 'I',
    PROTO_DOWNLOAD      = 'L',
    PROTO_DETECT        = 'D',
    PROTO_ERASE         = 'E',
    PROTO_COMPRESS      = 'Z',
    PROTO_PROGRAM       = 'P',
    PROTO_CKSUM         = 'C',
    PROTO_READ          = 'R',
    PROTO_RESET         = '0',
    PROTO_ERROR_CKSUM   = 'X',
    PROTO_ERROR_MEMORY  = 'M',
    PROTO_ERROR_FLASH_TIMEOUT = 'T',
    PROTO_ERROR_FLASH_COMMAND = 'C',
    PROTO_ERROR_FLASH_VPP     = 'P',
    PROTO_ERROR_FLASH_LOCKED  = 'L',
    PROTO_ERROR_VERIFY  = 'V',
    PROTO_CHECKSUM      = 'C',
    PROTO_VERSION       = 'V',
    PROTO_ERROR         = '?',

    PROTO_TRACE         = '$'
};



// Not really part of the protocol but as this header file is included by
// both PC side and target side source code, this is an easy place to put
// these difinitions.
enum ChipIdCodes {
    // Ulysses and Hercules
    CHIP_ID_ULYSSES_0  = 0xB2B5,
    CHIP_ID_ULYSSES_A  = 0xB335,
    CHIP_ID_HERCULES_A = 0xB334, // Correct revision designation?
    CHIP_ID_HERCULES_B = 0xB32C, // Correct revision designation?

    // Samson and Calypso
    CHIP_ID_CALYPSO_A  = 0xB2AC,
    CHIP_ID_CALYPSO_B  = 0xB396
};