FreeCalypso > hg > fc-magnetite

view src/cs/services/dar/dar_error_hdlr.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/****************************************************************************/
/*                                                                          */
/*  File Name:  dar_error_hdlr.c                                            */
/*                                                                          */
/*  Purpose:  This file contains routines used to report unrecoverable      */
/*                 memory errors that might occur.                          */
/*                                                                          */
/*  Version   0.1                                                           */
/*                                                                          */
/*  Date               Modification                                         */
/*  ------------------------------------------------------------------------*/
/*  27 September 2001  Create                                               */
/*                                                                          */
/*  Author:  Stephanie Gerthoux                                             */
/*                                                                          */
/* (C) Copyright 2001 by Texas Instruments Incorporated, All Rights Reserved*/
/****************************************************************************/

#include "rv/rv_defined_swe.h"
#ifdef RVM_DAR_SWE

   #include "rv/rv_general.h"
   #include "rvf/rvf_api.h"
   #include "dar/dar_error_hdlr_i.h"
   #include "dar/dar_macro_i.h"

   /********************************************************************************/
   /*                                                                              */
   /*    Function Name:   dar_error_trace                                          */
   /*                                                                              */
   /*    Purpose:         This function is used to report error occured during the */
   /*                     diagnose entity execution                                */
   /*                                                                              */
   /*    Input Parameters:                                                         */
   /*        status       - Contains the error code to be reported.                */
   /*                                                                              */
   /*    Output Parameters:                                                        */
   /*        None.                                                                 */
   /*                                                                              */
   /*    Global Parameters:                                                        */
   /*        None.                                                                 */
   /*                                                                              */
   /*    Note:                                                                     */
   /*        None.                                                                 */
   /*                                                                              */
   /*    Revision History:                                                         */
   /*       27 September 01           Create                                       */
   /*                                                                              */
   /********************************************************************************/
   void dar_error_trace(UINT8 error_id)
   {
      switch(error_id)
      {
         case DAR_ENTITY_NOT_START:
         {
            DAR_SEND_TRACE("DAR entity not started.",RV_TRACE_LEVEL_ERROR);
            break;
         }

         case DAR_ENTITY_NO_MEMORY:
         {
            DAR_SEND_TRACE("DAR entity has not enough memory",RV_TRACE_LEVEL_ERROR);
            break;
         }

         case DAR_ENTITY_BAD_PARAMETER:
         {
            DAR_SEND_TRACE("DAR entity has bad parameters",RV_TRACE_LEVEL_ERROR);
            break;
         }

         case DAR_ERROR_STOP_EVENT:
         {
            DAR_SEND_TRACE("DAR entity has received a stop error event",RV_TRACE_LEVEL_ERROR);
            break;
         }

         case DAR_ERROR_START_EVENT:
         {
             DAR_SEND_TRACE("DAR entity has received a start error event",RV_TRACE_LEVEL_ERROR);
             break;
         }

         case DAR_ENTITY_BAD_MESSAGE:
         {
            DAR_SEND_TRACE("DAR entity has received a bad message",RV_TRACE_LEVEL_ERROR);
            break;
         }  
      }
   }
   /************************* End of dar_error_trace function **********************/

   /********************************************************************************/
   /*                                                                              */
   /*    Function Name:   dar_ffs_error_trace                                      */
   /*                                                                              */
   /*    Purpose:         This function is used to report error occured during the */
   /*                     dar entity execution                                     */
   /*                                                                              */
   /*    Input Parameters:                                                         */
   /*        status       - Contains the error code to be reported.                */
   /*                                                                              */
   /*    Output Parameters:                                                        */
   /*        None.                                                                 */
   /*                                                                              */
   /*    Global Parameters:                                                        */
   /*        None.                                                                 */
   /*                                                                              */
   /*    Note:                                                                     */
   /*        None.                                                                 */
   /*                                                                              */
   /*    Revision History:                                                         */
   /*       29 october 01           Create                                         */
   /*                                                                              */
   /********************************************************************************/
   void dar_ffs_error_trace(UINT8 error_id)
   {
      switch(error_id)
      {
         case DAR_ENTITY_NO_MEMORY:
         {
            DAR_SEND_TRACE("DAR FFS entity has not enough memory",RV_TRACE_LEVEL_ERROR);
            break;
         }
         case DAR_ENTITY_FILE_ERROR:
         {
            DAR_SEND_TRACE("DAR FFS entity has received a wrong file name or the flash is not formatted",RV_TRACE_LEVEL_ERROR);
            break;
         }

         case DAR_ENTITY_FILE_NO_SAVED:
         {
            DAR_SEND_TRACE("DAR FFS entity has not saved the file",RV_TRACE_LEVEL_ERROR);
            break;
         }

         case DAR_ENTITY_FILE_NO_CLOSE:
         {
            DAR_SEND_TRACE("DAR FFS entity has not closed the file",RV_TRACE_LEVEL_ERROR);
            break;
         }
      } /* switch(error_id) */
   } /* dar_ffs_error_trace */
   /************************* End of dar_ffs_error_trace function **********************/

#endif /* #ifdef RVM_DAR_SWE */