FreeCalypso > hg > fc-magnetite

view src/cs/services/dar/dar_env.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/****************************************************************************/
/*                                                                          */
/*  File Name:  dar_env.h                                                   */
/*                                                                          */
/*  Purpose:  This file contains prototypes for Riviera Environment related */
/*            functions used to get info, start and stop the diagnose block.*/
/*                                                                          */
/*  Version   0.1                                                           */
/*                                                                          */
/*  Date               Modification                                         */
/*  ------------------------------------                                    */
/*  26 september 2001  Create                                               */
/*                                                                          */
/*  Author    Stephanie Gerthoux                                            */
/*                                                                          */
/* (C) Copyright 2001 by Texas Instruments Incorporated, All Rights Reserved*/
/****************************************************************************/

#include "rv/rv_defined_swe.h"
#ifdef RVM_DAR_SWE
   #include "dar/dar_structs_i.h"

   #include "dar/dar_pool_size.h"	/* Stack & Memory Bank sizes definitions */


   #ifndef __DAR_ENV_H_
      #define __DAR_ENV_H_

      /* memory bank size and watermark */
      #define DAR_MB_SIZE            DAR_MB1_SIZE
      #define DAR_MB_WATERMARK       DAR_MB_SIZE

      /* definition of RVT state*/
      typedef INT8 T_DAR_STATE;

      /* possible values */
      #define DAR_STARTED            (0)
      #define DAR_NOT_STARTED        (-1)

      /* generic functions declarations */
      T_RVM_RETURN dar_get_info (T_RVM_INFO_SWE   *infoSWEnt);

      T_RVM_RETURN dar_set_info(T_RVF_ADDR_ID addrId,
                                T_RV_RETURN    return_path[],
                                T_RVF_MB_ID    mbId[],
                                T_RVM_RETURN  (*callBackFctError) ( T_RVM_NAME SWEntName,
                                                                    T_RVM_RETURN errorCause,
                                                                    T_RVM_ERROR_TYPE errorType,
                                                                    T_RVM_STRING errorMsg) );

      T_RVM_RETURN dar_init (void);

      T_RVM_RETURN dar_stop (void);

      T_RVM_RETURN dar_kill (void);

   #endif /*__DAR_ENV_H_*/

#endif /* #ifdef RVM_DAR_SWE */