FreeCalypso > hg > fc-magnetite

view src/cs/services/atp/atp_gsm_gsm_api_dummy.c @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/*******************************************************************************
*
* File Name : atp_gsm_gsm_api.c
*
* This file contains dummy definition of all functions called by the ATP-GSM plug-in.
* These functions must be provided by CONDAT with their PS
*
*
* Version number	: 0.1      Date : 19-Dec-2001
*
* History			: 0.1  - Created 
*
* Author			: 
*
*   (C) Copyright 2001 by Texas Instruments Incorporated 
*****************************************************************************/

#ifdef _WINDOWS
// In this case, no GSM PS
// So need to define these dummy functions

#include "rv/rv_general.h"
#include "atp/atp_gsm_bt_api.h"
#include "atp/bti_at.h"

#if ( ((ATP_REGR != SW_COMPILED) && (ATP_MISC != SW_COMPILED))  )

/* functions define in GSM side and called by BT side */
void bti_at_init_cnf(T_BTI_ACK ack)
{

}

void bti_at_deinit_ind(void)
{
}
 
void bti_at_open_port_ind(T_BTI_PORT_NB gsm_port_nb,T_BTI_BT_PORT_INFO bt_custom_info)
{

}

void bti_at_close_port_ind(T_BTI_PORT_NB gsm_port_nb)
{
}
void bti_at_cmd_ind(T_BTI_PORT_NB gsm_port_nb,char * cmd)
{
}
void bti_at_cmd_cnf(T_BTI_PORT_NB gsm_port_nb)
{
}
void bti_at_abort_ind(T_BTI_PORT_NB gsm_port_nb)
{
}
void bti_data_ready_ind(T_BTI_PORT_NB port_nb,unsigned long nb_of_data)
{
}
void bti_get_gsm_data(T_BTI_PORT_NB port_nb,char * buffer, unsigned long nb_of_data)
{
}
void bti_data_ready_cnf(T_BTI_PORT_NB port_nb)
{
}

#endif

#endif