FreeCalypso > hg > fc-magnetite

view src/cs/services/Audio/audio_error_hdlr_i.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/****************************************************************************/
/*                                                                          */
/*  File Name:  audio_error_hdlr_i.h                                        */
/*                                                                          */
/*  Purpose:  This file contains routines used to report unrecoverable      */
/*            memory errors that might occur.                               */
/*                                                                          */
/*  Version   0.1                                                           */
/*                                                                          */
/*  Date        Modification                                                */
/*  ------------------------------------------------------------------------*/
/*  14 May 2001  Create                                                     */
/*                                                                          */
/*  Author      Francois Mazard - Stephanie Gerthoux                        */
/*                                                                          */
/* (C) Copyright 2001 by Texas Instruments Incorporated, All Rights Reserved*/
/****************************************************************************/

#include "rv/rv_defined_swe.h"
#ifdef RVM_AUDIO_MAIN_SWE
  #ifndef  _AUDIO_ERROR_HDLR_I_H
    #define  _AUDIO_ERROR_HDLR_I_H

    #include "l1_confg.h"

    /* error trace functions prototypes */
    #if (KEYBEEP)
      void audio_keybeep_error_trace(UINT8 error_id);
    #endif

    #if (TONE)
      void audio_tones_error_trace(UINT8 error_id);
    #endif

    #if (MELODY_E1)
      void audio_melody_E1_error_trace(UINT8 error_id);
    #endif

    #if (MELODY_E2)
      void audio_melody_E2_error_trace(UINT8 error_id);
    #endif

    #if (VOICE_MEMO)
      void audio_voice_memo_error_trace(UINT8 error_id);
    #endif

    void audio_mode_error_trace(UINT8 error_id);

    #if (SPEECH_RECO)
      void audio_sr_error_trace(UINT8 error_id);
    #endif

  #if (MELODY_E1) || (VOICE_MEMO) || (SPEECH_RECO)
    void audio_ffs_error_trace(UINT8 error_id);
  #endif

    #if (L1_VOICE_MEMO_AMR)
      void audio_voice_memo_amr_error_trace(UINT8 error_id);
    #endif

    #if (L1_AUDIO_DRIVER)
      void audio_driver_error_trace(UINT8 error_id);
    #endif

    #if (AUDIO_MEM_MANAGER)
      void audio_mem_error_trace(UINT8 error_id);
    #endif

    /* extern prototype */
    extern void audio_error_trace(UINT8 error_id);

    #if (L1_MIDI==1)
      void audio_midi_error_trace(UINT8 error_id);
    #endif

    /* Id of the error trace */
    #define AUDIO_ENTITY_NOT_START             (0)
    #define AUDIO_ENTITY_NO_MEMORY             (1)
    #define AUDIO_ERROR_STOP_EVENT             (2)
    #define AUDIO_ERROR_START_EVENT            (3)
    #define AUDIO_ERROR_INIT_EVENT             (4)
    #define AUDIO_ERROR_FREE_EVENT             (5)
    #define AUDIO_ENTITY_BAD_PARAMETER         (6)
    #define AUDIO_ENTITY_BAD_MESSAGE           (7)
    #define AUDIO_ERROR_MODE                   (8)
    #define AUDIO_ENTITY_FILE_ERROR            (9)
    #define AUDIO_ENTITY_FILE_NO_SAVED         (10)
    #define AUDIO_ENTITY_FILE_ALREADY_EXIST    (11)
    #define AUDIO_ENTITY_FILE_NO_CLOSE         (12)
    #define AUDIO_ENTITY_SPEECH_NO_SAVED       (13)
    #define AUDIO_ENTITY_MODEL_NO_SAVED        (14)
    #define AUDIO_ENTITY_BAD_DATABASE          (15)
    #define AUDIO_ENTITY_MODEL_NO_LOAD         (16)
    #define AUDIO_ENTITY_AUDIO_MODE_NO_LOADED  (17)
    #define AUDIO_ERROR_DOWNLOAD               (18)
    #define AUDIO_ERROR_NOT_DOWNLOAD           (19)
    #define AUDIO_ENTITY_LOAD_FILE_INSTR_ERROR (20)
    #define AUDIO_ERROR_INSTRUMENT_SIZE        (21)
    #define AUDIO_FEATURE_NOT_COMPILED         (22)
    #define AUDIO_ERROR_L1_START_EVENT         (23)
    #define AUDIO_ERROR_L1_STOP_EVENT          (24)
  #endif
#endif /* #ifdef RVM_AUDIO_MAIN_SWE */