FreeCalypso > hg > fc-magnetite

view src/cs/services/Audio/Audio_bgd/audio_bgd_structs_i.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/********************************************************************************/
/*                                                                              */
/*    File Name:   audio_structs_i.h                                            */
/*                                                                              */
/*    Purpose:     This file contains constants, data type, and data            */
/*                 structures that are used by the AUDIO's task.                */
/*                                                                              */
/*  Version   1                                                                 */
/*                                                                              */
/*  Date          Modification                                                  */
/*  ------------------------------------                                        */
/*  19 June 2003  Creation                                                      */
/*                                                                              */
/*  Author      Frederic Turgis                                                 */
/*                                                                              */
/* (C) Copyright 2001 by Texas Instruments Incorporated, All Rights Reserved.   */
/*                                                                              */
/********************************************************************************/
#include "rv/rv_defined_swe.h"

#ifdef RVM_AUDIO_BGD_SWE

  #ifndef  _AUDIO_BGD_STRUCTS_I_
  #define  _AUDIO_BGD_STRUCTS_I_

  #include "rv/rv_general.h"
  #include "rvf/rvf_api.h"
  #include "rvm/rvm_api.h"
  #include "rvm/rvm_gen.h"

  #ifdef __cplusplus
    extern "C"
    {
  #endif

  typedef struct
  {
    T_RVF_ADDR_ID          addrId;            /* AUDIO address ID.       */

    T_RVF_MB_ID            mb;   /* AUDIO internal memory bank. */

    T_RVM_RETURN           (*callBackFct)  (T_RVM_NAME        SWEntName,
                                            T_RVM_RETURN      errorCause,
                                            T_RVM_ERROR_TYPE  errorType,
                                            T_RVM_STRING      errorMsg);

    BOOLEAN                message_processed;
  }
  T_AUDIO_BGD_ENV_CTRL_BLK;

  #ifdef __cplusplus
    }
  #endif

  #endif // #ifndef  _AUDIO_BGD_STRUCTS_I_

#endif // #ifdef RVM_AUDIO_BGD_SWE