FreeCalypso > hg > fc-magnetite

view src/cs/layer1/p_include/l1p_vare.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/************* Revision Controle System Header *************
 *                  GSM Layer 1 software 
 * L1P_VAREX.H
 *
 *        Filename l1p_vare.h
 *  Copyright 2003 (C) Texas Instruments  
 *
 ************* Revision Controle System Header *************/

#ifdef L1P_ASYN_C

#if (LONG_JUMP == 3)
 #pragma DATA_SECTION(l1ps,".l1s_global")
 #pragma DATA_SECTION(l1pa_l1ps_com,".l1s_global")
 #pragma DATA_SECTION(l1ps_macs_com,".l1s_global")
 #pragma DATA_SECTION(l1ps_dsp_com,".l1s_global")
#endif

  // Global Packet L1A structure
  T_L1PA_GLOBAL    l1pa;

  // Global Packet L1S structure
  T_L1PS_GLOBAL    l1ps;

  // Common structure between L1A and L1S in packet mode
  T_L1PA_L1PS_COM  l1pa_l1ps_com;
 
  // Communication between L1S and MAC-S in packet mode
  T_L1PS_MACS_COM  l1ps_macs_com;

  // MCU / DSP interface
  T_L1PS_DSP_COM  l1ps_dsp_com;

#else
  extern T_L1PA_GLOBAL    l1pa;
  extern T_L1PS_GLOBAL    l1ps;
  extern T_L1PA_L1PS_COM  l1pa_l1ps_com;
  extern T_L1PS_DSP_COM   l1ps_dsp_com;
  extern T_L1PS_MACS_COM  l1ps_macs_com;

#endif