FreeCalypso > hg > fc-magnetite
view src/cs/layer1/include/l1_varex.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 945cf7f506b2 |
| children |
line wrap: on
line source
/************* Revision Controle System Header ************* * GSM Layer 1 software * L1_VAREX.H * * Filename l1_varex.h * Copyright 2003 (C) Texas Instruments * ************* Revision Controle System Header *************/ #ifdef L1_ASYNC_C #if (LONG_JUMP == 3) #pragma DATA_SECTION(l1s,".l1s_global") #pragma DATA_SECTION(l1s_dsp_com,".l1s_global") #pragma DATA_SECTION(l1a_l1s_com,".l1s_global") #pragma DATA_SECTION(l1s_tpu_com,".l1s_global") #pragma DATA_SECTION(l1_config,".l1s_global") #endif T_L1S_GLOBAL l1s; T_L1A_GLOBAL l1a; T_L1A_L1S_COM l1a_l1s_com; T_L1S_DSP_COM l1s_dsp_com; T_L1S_TPU_COM l1s_tpu_com; #if (L1_DYN_DSP_DWNLD == 1) // equivalent to an API_HISR flag T_L1_API_HISR l1_apihisr; T_L1A_API_HISR_COM l1a_apihisr_com; #endif // variables for L1 configuration T_L1_CONFIG l1_config; #else // L1_ASYNC_C extern T_L1S_GLOBAL l1s; extern T_L1A_GLOBAL l1a; extern T_L1A_L1S_COM l1a_l1s_com; extern T_L1S_DSP_COM l1s_dsp_com; extern T_L1S_TPU_COM l1s_tpu_com; #if (L1_DYN_DSP_DWNLD == 1) // equivalent to an API_HISR flag extern T_L1_API_HISR l1_apihisr; extern T_L1A_API_HISR_COM l1a_apihisr_com; #endif // variables for L1 configuration extern T_L1_CONFIG l1_config; #endif extern const UWORD8 ramBootCode[]; // dummy DSP code for boot.