FreeCalypso > hg > fc-magnetite

view src/cs/layer1/include/l1_rtt_macro.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/************* Revision Controle System Header *************
 *                  GSM Layer 1 software 
 * L1_RTT_MACRO.H
 *
 *        Filename %M%
 *  Copyright 2003 (C) Texas Instruments  
 *
 ************* Revision Controle System Header *************/

#if (defined RVM_RTT_SWE || (OP_L1_STANDALONE == 1))

#include "rvt_gen.h"
#include "rtt_gen.h"

extern T_TRACE_INFO_STRUCT trace_info;
                                                                    
/***********************************************************************************************************/
/* Macro for cell enabling checking                                                                        */
/***********************************************************************************************************/

#define SELECTED_BITMAP(enable_bit) \
  enable_bit < 32  ? (0x0001 << (enable_bit -   0)) & trace_info.current_config->rttl1_cell_enable[0] : \
  enable_bit < 64  ? (0x0001 << (enable_bit -  32)) & trace_info.current_config->rttl1_cell_enable[1] : \
  enable_bit < 96  ? (0x0001 << (enable_bit -  64)) & trace_info.current_config->rttl1_cell_enable[2] : \
  enable_bit < 128 ? (0x0001 << (enable_bit -  96)) & trace_info.current_config->rttl1_cell_enable[3] : \
  enable_bit < 160 ? (0x0001 << (enable_bit - 128)) & trace_info.current_config->rttl1_cell_enable[4] : \
  enable_bit < 192 ? (0x0001 << (enable_bit - 160)) & trace_info.current_config->rttl1_cell_enable[5] : \
  enable_bit < 224 ? (0x0001 << (enable_bit - 192)) & trace_info.current_config->rttl1_cell_enable[6] : \
                     (0x0001 << (enable_bit - 224)) & trace_info.current_config->rttl1_cell_enable[7]

/***********************************************************************************************************/
/* Macros for buffer filling                                                                               */
/***********************************************************************************************************/

//-----------------------------------------------------------------------------------------------------------
// L1 RTT cell filling: FN
                                     
#define RTTL1_FILL_FN(param1) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_FN)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_FN))) != NULL) \
      { \
        ((T_RTTL1_FN *)ptr)->fn          = param1; \
        ((T_RTTL1_FN *)ptr)->cell_id     = RTTL1_ENABLE_FN; \
      } \
  }

//-----------------------------------------------------------------------------------------------------------
// L1 RTT cell filling: Downlink burst
                                     
#define RTTL1_FILL_DL_BURST(param1,param2,param3,param4,param5,param6,param7) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_DL_BURST))                                                                  \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_DL_BURST))) != NULL) \
      { \
        ((T_RTTL1_DL_BURST *)ptr)->angle       = param1; \
        ((T_RTTL1_DL_BURST *)ptr)->snr         = param2; \
        ((T_RTTL1_DL_BURST *)ptr)->afc         = param3; \
        ((T_RTTL1_DL_BURST *)ptr)->task        = param4; \
        ((T_RTTL1_DL_BURST *)ptr)->pm          = param5; \
        ((T_RTTL1_DL_BURST *)ptr)->toa         = param6; \
        ((T_RTTL1_DL_BURST *)ptr)->input_level = param7; \
        ((T_RTTL1_DL_BURST *)ptr)->cell_id     = RTTL1_ENABLE_DL_BURST; \
      } \
  }                                                                                                           
                                                                                                              
//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: Uplink Normal Burst                                                                   
                                                                                                              
#define RTTL1_FILL_UL_NB(param1, param2, param3) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_UL_NB)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_UL_NB))) != NULL) \
      { \
        ((T_RTTL1_UL_NB *)ptr)->task    = param1; \
        ((T_RTTL1_UL_NB *)ptr)->ta      = param2; \
        ((T_RTTL1_UL_NB *)ptr)->txpwr   = param3; \
        ((T_RTTL1_UL_NB *)ptr)->cell_id = RTTL1_ENABLE_UL_NB; \
      } \
  }                                                                                                           
                                                                                                              
//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: Uplink Access Burst                                                                   
                                                                                                              
#define RTTL1_FILL_UL_AB(param1, param2) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_UL_AB)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_UL_AB))) != NULL) \
      { \
        ((T_RTTL1_UL_AB *)ptr)->task    = param1; \
        ((T_RTTL1_UL_AB *)ptr)->txpwr   = param2; \
        ((T_RTTL1_UL_AB *)ptr)->cell_id = RTTL1_ENABLE_UL_AB; \
      } \
  }                                                                                                           
                                                                                                              
//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: Full list measurement                                                                           
                                                                                                              
#define RTTL1_FILL_FULL_LIST_MEAS(param1, param2, param3, param4) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_FULL_LIST_MEAS)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_FULL_LIST_MEAS))) != NULL) \
      {                                                                                                       \
        ((T_RTTL1_FULL_LIST_MEAS *)ptr)->pm          = param1; \
        ((T_RTTL1_FULL_LIST_MEAS *)ptr)->input_level = param2; \
        ((T_RTTL1_FULL_LIST_MEAS *)ptr)->task        = param3; \
        ((T_RTTL1_FULL_LIST_MEAS *)ptr)->radio_freq  = param4; \
        ((T_RTTL1_FULL_LIST_MEAS *)ptr)->cell_id     = RTTL1_ENABLE_FULL_LIST_MEAS; \
      } \
  }                                                                                                           
                                                                                                              
//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: Full list measurement                                                                           
                                                                                                              
#define RTTL1_FILL_MON_MEAS(param1, param2, param3, param4) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_MON_MEAS)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_MON_MEAS))) != NULL) \
      { \
        ((T_RTTL1_MON_MEAS *)ptr)->pm          = param1; \
        ((T_RTTL1_MON_MEAS *)ptr)->input_level = param2; \
        ((T_RTTL1_MON_MEAS *)ptr)->task        = param3; \
        ((T_RTTL1_MON_MEAS *)ptr)->radio_freq  = param4; \
        ((T_RTTL1_MON_MEAS *)ptr)->cell_id     = RTTL1_ENABLE_MON_MEAS; \
      } \
  }                                                                                                           

//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: Downlink DCCH block                                                                   
                                                                                                              
#define RTTL1_FILL_DL_DCCH(param1, param2) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_DL_DCCH)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_DL_DCCH))) != NULL) \
      { \
        ((T_RTTL1_DL_DCCH *)ptr)->valid_flag    = param1; \
        ((T_RTTL1_DL_DCCH *)ptr)->physical_info = param2; \
        ((T_RTTL1_DL_DCCH *)ptr)->cell_id       = RTTL1_ENABLE_DL_DCCH; \
      } \
  }                                                                                                           
                                                                                                              
//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: Downlink PTCCH block                                                                  
                                                                                                              
#define RTTL1_FILL_DL_PTCCH(param1, param2) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_DL_PTCCH)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_DL_PTCCH))) != NULL) \
      { \
        ((T_RTTL1_DL_PTCCH *)ptr)->crc        = param1; \
        ((T_RTTL1_DL_PTCCH *)ptr)->ordered_ta = param2; \
        ((T_RTTL1_DL_PTCCH *)ptr)->cell_id    = RTTL1_ENABLE_DL_PTCCH; \
      } \
  }                                                                                                           
                                                                                                              
//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: Uplink DCCH block                                                                     
                                                                                                              
#define RTTL1_FILL_UL_DCCH \
  if(SELECTED_BITMAP(RTTL1_ENABLE_UL_DCCH)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_UL_DCCH))) != NULL) \
      { \
        ((T_RTTL1_UL_DCCH *)ptr)->cell_id = RTTL1_ENABLE_UL_DCCH; \
      } \
  }                                                                                                           
                                                                                                              
//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: Uplink SACCH block                                                                    
                                                                                                              
#define RTTL1_FILL_UL_SACCH(param1, param2, param3) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_UL_SACCH)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_UL_SACCH))) != NULL) \
      { \
        ((T_RTTL1_UL_SACCH *)ptr)->data_present   = param1; \
        ((T_RTTL1_UL_SACCH *)ptr)->reported_ta    = param2; \
        ((T_RTTL1_UL_SACCH *)ptr)->reported_txpwr = param3; \
        ((T_RTTL1_UL_SACCH *)ptr)->cell_id        = RTTL1_ENABLE_UL_SACCH; \
      } \
  }                                                                                                           
                                                                                                              
//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: Downlink PDTCH block                                                                  
                                                                                                              
#define RTTL1_FILL_DL_PDTCH(param1, param2, param3, param4, param5) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_DL_PDTCH)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_DL_PDTCH))) != NULL) \
      { \
        ((T_RTTL1_DL_PDTCH *)ptr)->mac_header = param1; \
        ((T_RTTL1_DL_PDTCH *)ptr)->tfi_result = param2; \
        ((T_RTTL1_DL_PDTCH *)ptr)->crc        = param3; \
        ((T_RTTL1_DL_PDTCH *)ptr)->cs_type    = param4; \
        ((T_RTTL1_DL_PDTCH *)ptr)->timeslot   = param5; \
        ((T_RTTL1_DL_PDTCH *)ptr)->cell_id    = RTTL1_ENABLE_DL_PDTCH; \
      } \
  }                                                                                                           
                                                                                                              
//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: Uplink PDTCH block                                                                    
                                                                                                              
#define RTTL1_FILL_UL_PDTCH(param1, param2, param3) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_UL_PDTCH)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_UL_PDTCH))) != NULL) \
      { \
        ((T_RTTL1_UL_PDTCH *)ptr)->cs_type      = param1; \
        ((T_RTTL1_UL_PDTCH *)ptr)->data_allowed = param2; \
        ((T_RTTL1_UL_PDTCH *)ptr)->timeslot     = param3; \
        ((T_RTTL1_UL_PDTCH *)ptr)->cell_id      = RTTL1_ENABLE_UL_PDTCH; \
      } \
  }                                                                                                           
                                                                                                              
//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: MAC-S error                                                                           
                                                                                                              
#define RTTL1_FILL_MACS_STATUS(param1, param2) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_MACS_STATUS)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_MACS_STATUS))) != NULL) \
      { \
        ((T_RTTL1_MACS_STATUS *)ptr)->status   = param1; \
        ((T_RTTL1_MACS_STATUS *)ptr)->timeslot = param2; \
        ((T_RTTL1_MACS_STATUS *)ptr)->cell_id  = RTTL1_ENABLE_MACS_STATUS; \
      } \
  }

//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: L1S task enable                                                                       
                                                                                                              
#define RTTL1_FILL_L1S_TASK_ENABLE(param1, param2) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_L1S_TASK_ENABLE)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_L1S_TASK_ENABLE))) != NULL) \
      { \
        ((T_RTTL1_L1S_TASK_ENABLE *)ptr)->bitmap1  = param1; \
        ((T_RTTL1_L1S_TASK_ENABLE *)ptr)->bitmap2  = param2; \
        ((T_RTTL1_L1S_TASK_ENABLE *)ptr)->cell_id  = RTTL1_ENABLE_L1S_TASK_ENABLE; \
      } \
  }

//----------------------------------------------------------------------------------------------------------- 
// L1 RTT cell filling: MFTAB trace                                                                       
                                                                                                              
#define RTTL1_FILL_MFTAB(param1) \
  if(SELECTED_BITMAP(RTTL1_ENABLE_MFTAB)) \
  { \
      T_RTT_PTR  ptr; \
\
      if ((ptr = trace_info.l1s_rtt_func.rtt_get_fill_ptr(trace_info.l1s_trace_user_id, sizeof(T_RTTL1_MFTAB))) != NULL) \
      { \
        ((T_RTTL1_MFTAB *)ptr)->func     = param1; \
        ((T_RTTL1_MFTAB *)ptr)->cell_id  = RTTL1_ENABLE_MFTAB; \
      } \
  }

/***********************************************************************************************************/ 
/* Macro for events                                                                                        */ 
/***********************************************************************************************************/
                                                                                                              
#define RTTL1_EVENT(id,size) \
  if (trace_info.current_config->rttl1_event_enable & (0x1 << id)) \
    trace_info.l1s_rtt_func.rtt_dump_buffer(trace_info.l1s_trace_user_id, size);
#else // RVM_RTT_SWE || OP_L1_STANDALONE

// No RTT: all macros are empty
#define SELECTED_BITMAP(enable_bit) (0)                                   
#define RTTL1_FILL_FN(param1)                                      
#define RTTL1_FILL_DL_BURST(param1,param2,param3,param4,param5,param6,param7)                                                                                                               
#define RTTL1_FILL_UL_NB(param1, param2, param3)                                                                                                               
#define RTTL1_FILL_UL_AB(param1, param2)                                                                                                               
#define RTTL1_FILL_FULL_LIST_MEAS(param1, param2, param3, param4)                                                                                                               
#define RTTL1_FILL_MON_MEAS(param1, param2, param3, param4)                                                                                                               
#define RTTL1_FILL_DL_DCCH(param1, param2)                                                                                                               
#define RTTL1_FILL_DL_PTCCH(param1, param2)                                                                                                               
#define RTTL1_FILL_UL_DCCH                                                                                                               
#define RTTL1_FILL_UL_SACCH(param1, param2, param3)                                                                                                              
#define RTTL1_FILL_DL_PDTCH(param1, param2, param3, param4, param5)                                                                                                              
#define RTTL1_FILL_UL_PDTCH(param1, param2, param3)                                                                                                              
#define RTTL1_FILL_MACS_STATUS(param1, param2)                                                                                                              
#define RTTL1_FILL_L1S_TASK_ENABLE(param1, param2)                                                                                                              
#define RTTL1_FILL_MFTAB(param1)
#define RTTL1_EVENT(id,size)

#endif // RVM_RTT_SWE || OP_L1_STANDALONE