FreeCalypso > hg > fc-magnetite
view src/cs/layer1/gtt_include/ctm/tonemod.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 945cf7f506b2 |
| children |
line wrap: on
line source
/* ******************************************************************************* * * COPYRIGHT (C) 2000 BY ERICSSON EUROLAB DEUTSCHLAND GmbH * 90411 NUERNBERG, GERMANY, Tel Int + 49 911 5217 100 * * The program(s) may be used and/or copied only with the * written permission from Ericsson or in accordance * with the terms and conditions stipulated in the agreement or * contract under which the program(s) have been supplied. * * Changes since October 13, 2000: * - The type mod_state_t includes a new member txbits_fifo_state now. * ******************************************************************************* * * File : tonemod.h * Purpose : header file for tonemod.c * ******************************************************************************* */ #ifndef tonemod_h #define tonemod_h "$Id: $" /* ******************************************************************************* * INCLUDE FILES ******************************************************************************* */ #include <fifo.h> /* ******************************************************************************* * DECLARATION OF PROTOTYPES ******************************************************************************* */ /* Define a type for the state variable of the function tonemod() */ typedef struct { WORD16 cntModulatedSamples; WORD16 actualBits[2]; fifo_state_t txbits_fifo_state; } mod_state_t; /* ---------------------------------------------------------------------- */ /* Function init_tonemod() */ /* *********************** */ /* This function has to be executed before tonemod() can be used. */ /* ---------------------------------------------------------------------- */ void init_tonemod(mod_state_t *mod_state); /* ---------------------------------------------------------------------- */ /* Function tonemod() */ /* ****************** */ /* Modulator of the Cellular Text Telephone Modem. */ /* The input vector bits_in must contain the bits that have to be */ /* transmitted. The length of bits_in must be even because always two */ /* bits are coded in parallel. */ /* Bits are either unipolar (i.e. {0, 1}) or bipolar (i.e. {-1, +1)}. */ /* The length of the output vector tones_out must be 20 times longer than */ /* the length of bits_in, since each pair of two bits is coded within a */ /* frame of 40 audio samples. */ /* ---------------------------------------------------------------------- */ void tonemod(WORD16 *tones_out, WORD16 *bits_in, WORD16 num_samples_tones_out, WORD16 num_bits_in, mod_state_t *mod_state); #endif