FreeCalypso > hg > fc-magnetite
view src/cs/layer1/gtt_include/ctm/conv_encoder.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 945cf7f506b2 |
| children |
line wrap: on
line source
/* ******************************************************************************* * * COPYRIGHT (C) 2000 BY ERICSSON EUROLAB DEUTSCHLAND GmbH * * The program(s) may be used and/or copied only with the * written permission from Ericsson or in accordance * with the terms and conditions stipulated in the agreement or * contract under which the program(s) have been supplied. * ******************************************************************************* * * File : conv_encoder.h * Purpose : Header file for conv_encoder.c * Author : Francisco Javier Gil Gomez * ******************************************************************************* * * Changes since October 13, 2000: * - added reset function conv_encoder_reset() * ******************************************************************************* * $Id: $ * */ #ifndef conv_encoder_h #define conv_encoder_h "$Id: $" #include "conv_poly.h" /* definition of encoder_t */ /***********************************************************************/ /* conv_encoder_init() */ /* ******************* */ /* Initialization of the convolutional encoder. */ /* */ /* output variables: */ /* *ptr_state Initialized state variable of the encoder */ /***********************************************************************/ void conv_encoder_init(conv_encoder_t* ptr_state); void conv_encoder_reset(conv_encoder_t* ptr_state); /***********************************************************************/ /* conv_encoder_exec() */ /* ******************* */ /* Execution of the convolutional encoder */ /* */ /* input variables: */ /* in Vector with net bits */ /* inbits Number of valid net bits in vector in. */ /* */ /* output variables: */ /* out Vector with the encoded gross bits. The gross */ /* bits are either 0 or 1. The vector out must */ /* have at least CHC_RATE*inbits elements. */ /* */ /* input/output variables: */ /* *ptr_state State variable of the encoder */ /* */ /***********************************************************************/ void conv_encoder_exec(conv_encoder_t* ptr_state, WORD16* in, WORD16 inbits, WORD16* out); #endif
