FreeCalypso > hg > fc-magnetite
view src/cs/drivers/drv_app/kpd/kpd_power_api.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 945cf7f506b2 |
| children |
line wrap: on
line source
/** * @file kpd_power_api.h * * API Definition for keypad driver, used bi PWR SWE. * * * @author Laurent Sollier (l-sollier@ti.com) * @version 0.1 */ /* * History: * * Date Author Modification * ---------------------------------------- * 11/02/2001 L Sollier Create * * * (C) Copyright 2001 by Texas Instruments Incorporated, All Rights Reserved */ #ifndef _KPD_POWER_API_H_ #define _KPD_POWER_API_H_ #include "kpd/kpd_cfg.h" #include "kpd/kpd_api.h" #include "rv/rv_general.h" #include "rvf/rvf_api.h" /* This structure defines the two functions to call when PWR key is pressed */ typedef struct { void (*pressed)(T_KPD_VIRTUAL_KEY_ID); void (*released)(void); } T_KPD_KEYPAD; #ifdef __cplusplus extern "C" { #endif /** * @name API functions * * API functions declarations. */ /*@{*/ /** * function: kpd_power_key_pressed * * This function is called by the PWR SWE when the PWR key is pressed. * * @return * - RV_OK if operation is successfull, * - RV_MEMORY_ERR if message could not be sent to the keypad task. * - RV_INTERNAL_ERR if keypad driver is not yet initialized. * */ T_RV_RET kpd_power_key_pressed(void); #ifdef __cplusplus } #endif #endif /* #ifndef _KPD_POWER_API_H_ */
