FreeCalypso > hg > fc-magnetite

view src/cs/drivers/drv_app/ffs/ffs_env.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/****************************************************************************/
/*                                                                          */
/*	File Name:	ffs_env.h													*/
/*                                                                          */
/*	Purpose:	This file contains prototypes for RV manager related	*/
/*				functions used to get info, start and stop the ffs block.	*/
/*                                                                          */
/*  Version		0.1															*/
/*																			*/
/* 	Date       	Modification												*/
/*  ------------------------------------									*/
/*  10/24/2000	Create														*/
/*																			*/
/*	Author		Pascal Puel 												*/
/*																			*/
/* (C) Copyright 2000 by Texas Instruments Incorporated, All Rights Reserved*/
/****************************************************************************/
#ifndef __FFS_ENV_H_
#define __FFS_ENV_H_


#include "rvm/rvm_gen.h"
#include "ffs/ffs_pool_size.h"	/* Stack & Memory Bank sizes definitions */


/* FFS mailbox */
#define FFS_MAILBOX	RVF_TASK_MBOX_0

/* min mem size: fd_max * fd_buf_size + 1k */
/* memory bank size and watermark */	
#define FFS_MB_PRIM_SIZE      FFS_MB1_SIZE

#define FFS_MB_PRIM_WATERMARK (FFS_MB_PRIM_SIZE - 3000)


typedef struct
{
	T_RVF_MB_ID	mbid;
	T_RVF_ADDR_ID   addr_id;
} T_FFS_TASK_INFO;

extern T_FFS_TASK_INFO ffs_task_info;

/* generic functions declarations */
T_RVM_RETURN ffs_get_info (T_RVM_INFO_SWE  *infoSWE);
T_RVM_RETURN ffs_set_info(T_RVF_ADDR_ID  addr_id,
						  T_RV_RETURN		ReturnPath[],
						  T_RVF_MB_ID mbId[],
						  T_RVM_RETURN (*callBackFct)(T_RVM_NAME SWEntName,
													  T_RVM_RETURN errorCause,
													  T_RVM_ERROR_TYPE errorType,
													  T_RVM_STRING errorMsg));
T_RVM_RETURN ffs_init (void);
T_RVM_RETURN ffs_start (void);
T_RVM_RETURN ffs_stop (void);
T_RVM_RETURN ffs_kill (void);

#endif /*__FFS_ENV_H_*/