FreeCalypso > hg > fc-magnetite
view src/cs/drivers/drv_app/ffs/board/tdata.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 945cf7f506b2 |
| children |
line wrap: on
line source
/****************************************************************************** * Flash File System (ffs) * Idea, design and coding by Mads Meisner-Jensen, mmj@ti.com * * ffs test data * * $Id: tdata.h 1.4 Mon, 08 Apr 2002 10:02:52 +0200 tsj $ * ******************************************************************************/ #define TEST_DATA_NUM 11 /****************************************************************************** * Global Macros ******************************************************************************/ #define TDATA(index) (char *) tdata[index], sdata[index] // Make <addr, size> arguments with a string #define TDATA_STRING(string) (char *) string, strlen(string) // This is guaranteed to be at least the size of fs.filesize_max // NOTEME: not any more #define TDATA_HUGE (TEST_DATA_NUM - 1) // This is to use while testing in target #define TDATA_BIG 3 // This is guaranteed to be at most four bytes #define TDATA_TINY (0) /****************************************************************************** * Globals and Prototypes ******************************************************************************/ extern char *tdata[TEST_DATA_NUM]; extern int sdata[TEST_DATA_NUM]; int test_tdata_init(void);