FreeCalypso > hg > fc-magnetite

view src/cs/drivers/drv_app/abb/abb_inth.h @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 945cf7f506b2
children
line wrap: on
line source

/**********************************************************************************/
/*            TEXAS INSTRUMENTS INCORPORATED PROPRIETARY INFORMATION              */
/*                                                                                */
/*   Property of Texas Instruments -- For  Unrestricted  Internal  Use  Only      */
/*   Unauthorized reproduction and/or distribution is strictly prohibited.  This  */
/*   product  is  protected  under  copyright  law  and  trade  secret law as an  */
/*   unpublished work.  Created 1987, (C) Copyright 1997 Texas Instruments.  All  */
/*   rights reserved.                                                             */
/*                                                                                */
/*                                                                                */
/*   Filename          : abb_inth.h                                               */
/*                                                                                */
/*   Description       : Functions to manage the ABB device interrupt.            */
/*                       The Serial Port Interface is used to connect the TI  	  */
/*					          	 Analog BaseBand (ABB).				    			      	          */
/*						           It is assumed that the ABB is connected as the SPI       */																				  
/*                       device 0, and ABB interrupt is mapped as external IT.    */																				  
/*														                                      						  */
/*   Author            : Pascal PUEL                                              */
/*                                                                                */
/*   Version number   : 1.0                                                       */
/*                                                                                */
/*   Date and time    : Jan 2003                                                  */
/*                                                                                */
/*   Previous delta   : Creation                                                  */
/*                                                                                */
/**********************************************************************************/
/*                                                                                */
/*   17/12/03                                                                     */
/*   The original abb_inth.h has been splitted between the actual abb_inth.h      */
/*   located in drv_apps directory and abb_inth_core.h located in drv_core        */
/*   directory.                                                                   */
/*   abb_core_inth.h must be included in abb_inth.h.                              */
/*                                                                                */
/**********************************************************************************/

#ifndef __ABB_INTH_H__
#define __ABB_INTH_H__

  #include "main/sys_types.h"
  #include "abb/abb_core_inth.h" 

  #ifndef _WINDOWS

    #include "l1sw.cfg"
    #include "chipset.cfg"
  
    /****************************************************************/
    /* Power ON/OFF key definition.                                 */
    /****************************************************************/
    // If <ON/OFF> key is pressed more than 20 TDMAs, it's a Hook-ON
    #define SHORT_OFF_KEY_PRESSED  (20)
  
    // If <ON/OFF> key is pressed more than 160 TDMAs, it's a Hook-ON AND then Power-OFF
    #define OFF_LOOP_COUNT   (8)
    #define LONG_OFF_KEY_PRESSED   (OFF_LOOP_COUNT * SHORT_OFF_KEY_PRESSED)
  
  #endif   // _WINDOWS
  
  // PROTOTYPES
  void spi_abb_read_int_reg_callback(SYS_UWORD16 *read_value);

#endif  // __ABB_INTH_H__