FreeCalypso > hg > fc-magnetite

view cdg3/cdginc-locosto/p_dl.val @ 516:1ed9de6c90bd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents c15047b3d00d
children
line wrap: on
line source

/*
+--------------------------------------------------------------------------+
| PROJECT : PROTOCOL STACK                                                 |
| FILE    : p_dl.val                                                       |
| SOURCE  : "sap\dl.pdf"                                                   |
| LastModified : "2004-04-28"                                              |
| IdAndVersion : "8010.100.02.010"                                         |
| SrcFileTime  : "Thu Nov 29 09:40:06 2007"                                |
| Generated by CCDGEN_2.5.5A on Thu Sep 25 09:18:53 2014                   |
|           !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!!                |
+--------------------------------------------------------------------------+
*/

/* PRAGMAS
 * PREFIX                 : DL
 * COMPATIBILITY_DEFINES  : NO
 * ALWAYS_ENUM_IN_VAL_FILE: YES
 * ENABLE_GROUP: NO
 * CAPITALIZE_TYPENAME: NO
 */


#ifndef P_DL_VAL
#define P_DL_VAL


#define CDG_ENTER__P_DL_VAL

#define CDG_ENTER__FILENAME _P_DL_VAL
#define CDG_ENTER__P_DL_VAL__FILE_TYPE CDGINC
#define CDG_ENTER__P_DL_VAL__LAST_MODIFIED _2004_04_28
#define CDG_ENTER__P_DL_VAL__ID_AND_VERSION _8010_100_02_010

#define CDG_ENTER__P_DL_VAL__SRC_FILE_TIME _Thu_Nov_29_09_40_06_2007

#include "CDG_ENTER.h"

#undef CDG_ENTER__P_DL_VAL

#undef CDG_ENTER__FILENAME

/* #include "p_8010_152_ps_include.val" */   /* Access values independent from the corresponding h-file. */

/* #include "p_8010_153_cause_include.val" */   /* Access values independent from the corresponding h-file. */

/* #include "p_8010_147_l1_include.val" */   /* Access values independent from the corresponding h-file. */


// VALTAB-FF: !TI_DUAL_MODE 
/*
 * Enum to value table VAL_l2_channel
 * CCDGEN:WriteEnum_Count==163
 */
#ifndef __T_DL_VAL_l2_channel__
#define __T_DL_VAL_l2_channel__
typedef enum
{
  DL_L2_CHANNEL_SACCH            = 0x1,           /* SACCH block                    */
  DL_L2_CHANNEL_SDCCH            = 0x2,           /* SDCCH block                    */
  DL_L2_CHANNEL_FACCH_H          = 0x3,           /* FACCH halfrate block           */
  DL_L2_CHANNEL_FACCH_F          = 0x4,           /* FACCH fullrate block           */
  DL_L2_CHANNEL_CCCH             = 0x5,           /* CCCH block                     */
  DL_L2_CHANNEL_NBCCH            = 0x6,           /* normal BCCH block              */
  DL_L2_CHANNEL_PCH              = 0x7,           /* PCH block                      */
  DL_L2_CHANNEL_EPCH             = 0x8,           /* extended PCH block             */
  DL_L2_CHANNEL_CBCH             = 0x9,           /* CBCH block                     */
  DL_L2_CHANNEL_EBCCH            = 0xa            /* extended BCCH                  */
}T_DL_VAL_l2_channel;
#endif

/*
 * Enum to value table VAL_sapi
 * CCDGEN:WriteEnum_Count==164
 */
#ifndef __T_DL_VAL_sapi__
#define __T_DL_VAL_sapi__
typedef enum
{
// VAL-FF: !TI_DUAL_MODE  
  DL_SAPI_0                      = 0x0,           /* SAPI 0                         */
// VAL-FF: !TI_DUAL_MODE  
  DL_SAPI_3                      = 0x3            /* SAPI 3                         */
}T_DL_VAL_sapi;
#endif

/*
 * Enum to value table VAL_indication
 * CCDGEN:WriteEnum_Count==165
 */
#ifndef __T_DL_VAL_indication__
#define __T_DL_VAL_indication__
typedef enum
{
  DL_ALL_DONE                    = 0x0,           /* no unacknowledges or unserved data requests */
  DL_UNSERVED                    = 0x1            /* unserved data requests         */
}T_DL_VAL_indication;
#endif

/*
 * Enum to value table VAL_mode
 * CCDGEN:WriteEnum_Count==166
 */
#ifndef __T_DL_VAL_mode__
#define __T_DL_VAL_mode__
typedef enum
{
  DL_NORMAL_RELEASE              = 0x0,           /* normal release procedure       */
  DL_LOCAL_END_RELEASE           = 0x1            /* local end release procedure    */
}T_DL_VAL_mode;
#endif

/*
 * Enum to value table VAL_cnf
 * CCDGEN:WriteEnum_Count==167
 */
#ifndef __T_DL_VAL_cnf__
#define __T_DL_VAL_cnf__
typedef enum
{
  DL_NO_CONFIRMATION             = 0x0            /* no confimation necessary       */
}T_DL_VAL_cnf;
#endif

/*
 * Enum to value table VAL_cs
 * CCDGEN:WriteEnum_Count==168
 */
#ifndef __T_DL_VAL_cs__
#define __T_DL_VAL_cs__
typedef enum
{
// VAL-FF: !TI_DUAL_MODE  
  DL_INFO_FIELD_MISMATCH         = 0x0            /* different information fields   */
}T_DL_VAL_cs;
#endif

/*
 * user defined constants
 */
#define DL_MAX_SDU_LEN                 (0x1)      
#define DL_N201_SACCH_A_B              (0x12)     
#define DL_N201_DCCH_A_B               (0x14)     
#define DL_N201_Bbis                   (0x17)     
#define DL_N201_SACCH_Bter             (0x15)     
#define DL_N201_DCCH_Bter              (0x17)     
#define DL_MAX_L2_FRAME_SIZE           (0x17)     
#define DL_SPD_PID                     (0x10)     

#include "CDG_LEAVE.h"


#endif