FreeCalypso > hg > fc-magnetite
view cdg211/cdginc/p_ra.h @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | 56abf6cf8a0b |
| children |
line wrap: on
line source
/* +--------------------------------------------------------------------------+ | PROJECT : PROTOCOL STACK | | FILE : p_ra.h | | SOURCE : "__out__\g23m_dfile\prim\ra.pdf" | | LastModified : "2002-04-26" | | IdAndVersion : "8411.102.98.204" | | SrcFileTime : "Mon Nov 24 15:51:06 2003" | | Generated by CCDGEN_2.5.5 on Fri Jun 08 13:59:16 2007 | | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! | +--------------------------------------------------------------------------+ */ /* PRAGMAS * PREFIX : NONE * COMPATIBILITY_DEFINES : NO (require PREFIX) * ALWAYS_ENUM_IN_VAL_FILE: NO * ENABLE_GROUP: NO * CAPITALIZE_TYPENAME: NO */ #ifndef P_RA_H #define P_RA_H #define CDG_ENTER__P_RA_H #define CDG_ENTER__FILENAME _P_RA_H #define CDG_ENTER__P_RA_H__FILE_TYPE CDGINC #define CDG_ENTER__P_RA_H__LAST_MODIFIED _2002_04_26 #define CDG_ENTER__P_RA_H__ID_AND_VERSION _8411_102_98_204 #define CDG_ENTER__P_RA_H__SRC_FILE_TIME _Mon_Nov_24_15_51_06_2003 #include "CDG_ENTER.h" #undef CDG_ENTER__P_RA_H #undef CDG_ENTER__FILENAME #include "p_ra.val" /* * End of substructure section, begin of primitive definition section */ #ifndef __T_RA_ACTIVATE_REQ__ #define __T_RA_ACTIVATE_REQ__ /* * * CCDGEN:WriteStruct_Count==1897 */ typedef struct { U8 model; /*< 0: 1> transfer protocol model */ U8 tra_rate; /*< 1: 1> transmission rate */ U8 user_rate; /*< 2: 1> user rate */ U8 ndb; /*< 3: 1> number data bits */ U8 nsb; /*< 4: 1> number stop bits */ U8 _align0; /*< 5: 1> alignment */ U8 _align1; /*< 6: 1> alignment */ U8 _align2; /*< 7: 1> alignment */ } T_RA_ACTIVATE_REQ; #endif #ifndef __T_RA_DEACTIVATE_REQ__ #define __T_RA_DEACTIVATE_REQ__ /* * * CCDGEN:WriteStruct_Count==1898 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_RA_DEACTIVATE_REQ; #endif #ifndef __T_RA_READY_IND__ #define __T_RA_READY_IND__ /* * * CCDGEN:WriteStruct_Count==1899 */ typedef struct { U8 req_frames; /*< 0: 1> requested frames */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ } T_RA_READY_IND; #endif #ifndef __T_RA_DATA_REQ__ #define __T_RA_DATA_REQ__ /* * * CCDGEN:WriteStruct_Count==1900 */ typedef struct { U8 fr_type; /*< 0: 1> frame type */ U8 dtx_flg; /*< 1: 1> discontinuous transmission flag */ U8 status; /*< 2: 1> V24 Status */ U8 reserved; /*< 3: 1> Reserved */ T_sdu sdu; /*< 4: ? > Service Data Unit */ } T_RA_DATA_REQ; #endif #ifndef __T_RA_BREAK_REQ__ #define __T_RA_BREAK_REQ__ /* * * CCDGEN:WriteStruct_Count==1901 */ typedef struct { U16 break_len; /*< 0: 2> Break Length */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ } T_RA_BREAK_REQ; #endif #ifndef __T_RA_DATA_IND__ #define __T_RA_DATA_IND__ /* * * CCDGEN:WriteStruct_Count==1902 */ typedef struct { U8 fr_type; /*< 0: 1> frame type */ U8 status; /*< 1: 1> V24 Status */ U8 reserved; /*< 2: 1> Reserved */ U8 _align0; /*< 3: 1> alignment */ T_sdu sdu; /*< 4: ? > Service Data Unit */ } T_RA_DATA_IND; #endif #ifndef __T_RA_ACTIVATE_CNF__ #define __T_RA_ACTIVATE_CNF__ /* * * CCDGEN:WriteStruct_Count==1903 */ typedef struct { U8 ack_flg; /*< 0: 1> acknowledge flag */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ } T_RA_ACTIVATE_CNF; #endif #ifndef __T_RA_DEACTIVATE_CNF__ #define __T_RA_DEACTIVATE_CNF__ /* * * CCDGEN:WriteStruct_Count==1904 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_RA_DEACTIVATE_CNF; #endif #ifndef __T_RA_BREAK_IND__ #define __T_RA_BREAK_IND__ /* * * CCDGEN:WriteStruct_Count==1905 */ typedef struct { U16 break_len; /*< 0: 2> Break Length */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ } T_RA_BREAK_IND; #endif #ifndef __T_RA_DETECT_REQ__ #define __T_RA_DETECT_REQ__ /* * * CCDGEN:WriteStruct_Count==1906 */ typedef struct { U8 detect; /*< 0: 1> Detect mode */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ } T_RA_DETECT_REQ; #endif #ifndef __T_RA_MODIFY_REQ__ #define __T_RA_MODIFY_REQ__ /* * * CCDGEN:WriteStruct_Count==1907 */ typedef struct { U8 tra_rate; /*< 0: 1> transmission rate */ U8 user_rate; /*< 1: 1> user rate */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ } T_RA_MODIFY_REQ; #endif #ifndef __T_RA_MODIFY_CNF__ #define __T_RA_MODIFY_CNF__ /* * * CCDGEN:WriteStruct_Count==1908 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_RA_MODIFY_CNF; #endif #ifndef __T_RA_DATATRANS_REQ__ #define __T_RA_DATATRANS_REQ__ /* * * CCDGEN:WriteStruct_Count==1909 */ typedef struct { U8 dummy; /*< 0: 1> no parameters */ } T_RA_DATATRANS_REQ; #endif #ifndef __T_SHM_TICK_REQ__ #define __T_SHM_TICK_REQ__ /* * * CCDGEN:WriteStruct_Count==1910 */ typedef struct { U8 tick_dir; /*< 0: 1> tick direction */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ } T_SHM_TICK_REQ; #endif #ifndef __T_SHM_DATA_REQ__ #define __T_SHM_DATA_REQ__ /* * * CCDGEN:WriteStruct_Count==1911 */ typedef struct { U8 fr_type; /*< 0: 1> frame type */ U8 dtx_flg; /*< 1: 1> discontinuous transmission flag */ U8 status; /*< 2: 1> V24 Status */ U8 reserved; /*< 3: 1> Reserved */ T_sdu sdu; /*< 4: ? > Service Data Unit */ } T_SHM_DATA_REQ; #endif #ifndef __T_SHM_READ_REQ__ #define __T_SHM_READ_REQ__ /* * * CCDGEN:WriteStruct_Count==1912 */ typedef struct { U8 model; /*< 0: 1> transfer protocol model */ U8 _align0; /*< 1: 1> alignment */ U8 _align1; /*< 2: 1> alignment */ U8 _align2; /*< 3: 1> alignment */ } T_SHM_READ_REQ; #endif #ifndef __T_SHM_DATA_IND__ #define __T_SHM_DATA_IND__ /* * * CCDGEN:WriteStruct_Count==1913 */ typedef struct { U8 fr_type; /*< 0: 1> frame type */ U8 status; /*< 1: 1> V24 Status */ U8 reserved; /*< 2: 1> Reserved */ U8 _align0; /*< 3: 1> alignment */ T_sdu sdu; /*< 4: ? > Service Data Unit */ } T_SHM_DATA_IND; #endif #ifndef __T_SHM_BITSET_REQ__ #define __T_SHM_BITSET_REQ__ /* * * CCDGEN:WriteStruct_Count==1914 */ typedef struct { U8 id; /*< 0: 1> Bit Identity */ U8 _align0; /*< 1: 1> alignment */ U16 value; /*< 2: 2> Bits value */ } T_SHM_BITSET_REQ; #endif #ifndef __T_SHM_BITTEST_REQ__ #define __T_SHM_BITTEST_REQ__ /* * * CCDGEN:WriteStruct_Count==1915 */ typedef struct { U8 offset; /*< 0: 1> Address offset */ U8 _align0; /*< 1: 1> alignment */ U16 mask; /*< 2: 2> Bit mask */ } T_SHM_BITTEST_REQ; #endif #ifndef __T_SHM_BITTEST_IND__ #define __T_SHM_BITTEST_IND__ /* * * CCDGEN:WriteStruct_Count==1916 */ typedef struct { U16 value; /*< 0: 2> Bits value */ U8 _align0; /*< 2: 1> alignment */ U8 _align1; /*< 3: 1> alignment */ } T_SHM_BITTEST_IND; #endif #include "CDG_LEAVE.h" #endif