comparison src/g23m-aci/aci/ati_cmd.c @ 600:8f50b202e81f

board preprocessor conditionals: prep for more FC hw in the future This change eliminates the CONFIG_TARGET_FCDEV3B preprocessor symbol and all preprocessor conditionals throughout the code base that tested for it, replacing them with CONFIG_TARGET_FCFAM or CONFIG_TARGET_FCMODEM. These new symbols are specified as follows: CONFIG_TARGET_FCFAM is intended to cover all hardware designs created by Mother Mychaela under the FreeCalypso trademark. This family will include modem products (repackagings of the FCDEV3B, possibly with RFFE or even RF transceiver changes), and also my desired FreeCalypso handset product. CONFIG_TARGET_FCMODEM is intended to cover all FreeCalypso modem products (which will be firmware-compatible with the FCDEV3B if they use TI Rita transceiver, or will require a different fw build if we switch to one of Silabs Aero transceivers), but not the handset product. Right now this CONFIG_TARGET_FCMODEM preprocessor symbol is used to conditionalize everything dealing with MCSI. At the present moment the future of FC hardware evolution is still unknown: it is not known whether we will ever have any beyond-FCDEV3B hardware at all (contingent on uncertain funding), and if we do produce further FC hardware designs, it is not known whether they will retain the same FIC modem core (triband), if we are going to have a quadband design that still retains the classic Rita transceiver, or if we are going to switch to Silabs Aero II or some other transceiver. If we produce a quadband modem that still uses Rita, it will run exactly the same fw as the FCDEV3B thanks to the way we define TSPACT signals for the RF_FAM=12 && CONFIG_TARGET_FCFAM combination, and the current fcdev3b build target will be renamed to fcmodem. OTOH, if that putative quadband modem will be Aero-based, then it will require a different fw build target, the fcdev3b target will stay as it is, and the two targets will both define CONFIG_TARGET_FCFAM and CONFIG_TARGET_FCMODEM, but will have different RF_FAM numbers. But no matter which way we are going to evolve, it is not right to have conditionals on CONFIG_TARGET_FCDEV3B in places like ACI, and the present change clears the way for future evolution.
author Mychaela Falconia <falcon@freecalypso.org>
date Mon, 01 Apr 2019 01:05:24 +0000
parents f18b29e27be5
children 92dbfa906f66
comparison
equal deleted inserted replaced
599:4626d7a955de 600:8f50b202e81f
741 EXTERN T_ATI_RSLT atAtPOFF (CHAR *cl, UBYTE srcId); 741 EXTERN T_ATI_RSLT atAtPOFF (CHAR *cl, UBYTE srcId);
742 EXTERN T_ATI_RSLT atAtRST (CHAR *cl, UBYTE srcId); 742 EXTERN T_ATI_RSLT atAtRST (CHAR *cl, UBYTE srcId);
743 EXTERN T_ATI_RSLT atAtBAND (CHAR *cl, UBYTE srcId); 743 EXTERN T_ATI_RSLT atAtBAND (CHAR *cl, UBYTE srcId);
744 744
745 /* FreeCalypso additions */ 745 /* FreeCalypso additions */
746 #if defined(CONFIG_TARGET_DSAMPLE) || defined(CONFIG_TARGET_FCDEV3B) 746 #if defined(CONFIG_TARGET_DSAMPLE) || defined(CONFIG_TARGET_FCFAM)
747 EXTERN T_ATI_RSLT atAtSPKR (char *cl, UBYTE srcId); 747 EXTERN T_ATI_RSLT atAtSPKR (char *cl, UBYTE srcId);
748 EXTERN T_ATI_RSLT queatAtSPKR (char *cl, UBYTE srcId); 748 EXTERN T_ATI_RSLT queatAtSPKR (char *cl, UBYTE srcId);
749 #endif 749 #endif
750 #ifdef CONFIG_TARGET_FCDEV3B 750 #ifdef CONFIG_TARGET_FCMODEM
751 EXTERN T_ATI_RSLT atAtVPATH (char *cl, UBYTE srcId); 751 EXTERN T_ATI_RSLT atAtVPATH (char *cl, UBYTE srcId);
752 EXTERN T_ATI_RSLT queatAtVPATH (char *cl, UBYTE srcId); 752 EXTERN T_ATI_RSLT queatAtVPATH (char *cl, UBYTE srcId);
753 EXTERN T_ATI_RSLT atAtVSEL (char *cl, UBYTE srcId); 753 EXTERN T_ATI_RSLT atAtVSEL (char *cl, UBYTE srcId);
754 EXTERN T_ATI_RSLT queatAtVSEL (char *cl, UBYTE srcId); 754 EXTERN T_ATI_RSLT queatAtVSEL (char *cl, UBYTE srcId);
755 #endif 755 #endif
1207 {"@ST", AT_CMD_P_ST, atAtST, test_gen, queatAtST, "%s: (-26,-23,-20,-17,-14,-11,-8,-5,-2,1)"}, 1207 {"@ST", AT_CMD_P_ST, atAtST, test_gen, queatAtST, "%s: (-26,-23,-20,-17,-14,-11,-8,-5,-2,1)"},
1208 {"@POFF", AT_CMD_P_POFF, atAtPOFF, 0, 0, 0}, 1208 {"@POFF", AT_CMD_P_POFF, atAtPOFF, 0, 0, 0},
1209 {"@RST", AT_CMD_P_RST, atAtRST, 0, 0, 0}, 1209 {"@RST", AT_CMD_P_RST, atAtRST, 0, 0, 0},
1210 {"@BAND", AT_CMD_P_BAND, atAtBAND, 0, 0, 0}, 1210 {"@BAND", AT_CMD_P_BAND, atAtBAND, 0, 0, 0},
1211 /* FreeCalypso additions */ 1211 /* FreeCalypso additions */
1212 #if defined(CONFIG_TARGET_DSAMPLE) || defined(CONFIG_TARGET_FCDEV3B) 1212 #if defined(CONFIG_TARGET_DSAMPLE) || defined(CONFIG_TARGET_FCFAM)
1213 {"@SPKR", AT_CMD_AT_SPKR, atAtSPKR, test_gen, queatAtSPKR, "%s: (0,1)"}, 1213 {"@SPKR", AT_CMD_AT_SPKR, atAtSPKR, test_gen, queatAtSPKR, "%s: (0,1)"},
1214 #endif 1214 #endif
1215 #ifdef CONFIG_TARGET_FCDEV3B 1215 #ifdef CONFIG_TARGET_FCMODEM
1216 {"@VPATH", AT_CMD_AT_VPATH, atAtVPATH,test_gen, queatAtVPATH,"%s: (0-2)"}, 1216 {"@VPATH", AT_CMD_AT_VPATH, atAtVPATH,test_gen, queatAtVPATH,"%s: (0-2)"},
1217 {"@VSEL", AT_CMD_AT_VSEL, atAtVSEL, test_gen, queatAtVSEL, "%s: (0,1)"}, 1217 {"@VSEL", AT_CMD_AT_VSEL, atAtVSEL, test_gen, queatAtVSEL, "%s: (0,1)"},
1218 #endif 1218 #endif
1219 {"@SND", AT_CMD_AT_SND, atAtSND, 0, 0, 0}, 1219 {"@SND", AT_CMD_AT_SND, atAtSND, 0, 0, 0},
1220 {"@E1", AT_CMD_AT_E1, atAtE1, 0, 0, 0}, 1220 {"@E1", AT_CMD_AT_E1, atAtE1, 0, 0, 0},