FreeCalypso > hg > fc-magnetite
annotate src/cs/layer1/dsp1/patch_file36_10.c @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | d6da3c06d484 |
| children |
| rev | line source |
|---|---|
|
513
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 /* |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 * The only DSP patch code we have for 36_10 is the dynamic download version |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 * which we have extracted from the world's last surviving copy of TCS211 fw |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 * for Calypso modems. The purpose of this cheesy patch_file36_10.c wrapper |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 * is to allow experimental builds with L1_DYN_DSP_DWNLD=0: we use the static |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 * portion of our only available patch code, and simply not do the dynamic part. |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 * |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 * This configuration is intended only for experiments, not for production! |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 * The dynamic parts of the DSP patch code which this configuration omits |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 * are surely there for some good reason, and we can only guess what we are |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 * going to destabilize by disabling them. |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 */ |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 |
|
d6da3c06d484
patch_file36_10.c trivial wrapper added for L1_DYN_DSP_DWNLD=0 experiments
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 #include "patch_file36_10_dyn_dwl.c" |
