FreeCalypso > hg > fc-magnetite
annotate scripts/config-headers.sh @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | fd8227e3047d |
| children | 92dbfa906f66 |
| rev | line source |
|---|---|
|
6
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 #!/bin/sh |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 |
|
144
fd8227e3047d
config headers overhaul
Mychaela Falconia <falcon@freecalypso.org>
parents:
14
diff
changeset
|
3 if [ $# != 2 ] |
|
6
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 then |
|
144
fd8227e3047d
config headers overhaul
Mychaela Falconia <falcon@freecalypso.org>
parents:
14
diff
changeset
|
5 echo "usage: $0 srvc-flavor rv-swe-flavor" 1>&2 |
|
6
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 exit 1 |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 fi |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 if [ -z "$TARGET" ] |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 then |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 echo "Error: TARGET= must be passed via environment" 1>&2 |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 exit 1 |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 fi |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 if [ -z "$BUILD_DIR" ] |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 then |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 echo "Error: BUILD_DIR= must be passed via environment" 1>&2 |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
18 exit 1 |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
19 fi |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
20 |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
21 set -e |
|
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
22 |
|
14
86e83045be37
scripts/config-headers.sh: allow this script to be re-run
Mychaela Falconia <falcon@freecalypso.org>
parents:
6
diff
changeset
|
23 rm -rf $BUILD_DIR/config |
|
144
fd8227e3047d
config headers overhaul
Mychaela Falconia <falcon@freecalypso.org>
parents:
14
diff
changeset
|
24 cp -r cfg-headers/base $BUILD_DIR/config |
|
fd8227e3047d
config headers overhaul
Mychaela Falconia <falcon@freecalypso.org>
parents:
14
diff
changeset
|
25 cp cfg-headers/$1/* $BUILD_DIR/config |
|
fd8227e3047d
config headers overhaul
Mychaela Falconia <falcon@freecalypso.org>
parents:
14
diff
changeset
|
26 cp cfg-headers/rv_swe-$2.h $BUILD_DIR/config/rv_swe.h |
|
6
c01d2500a998
beginning of build system: crafting config headers into place
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
27 cp targets/$TARGET.h $BUILD_DIR/config/fc-target.cfg |
