annotate fcdev3b-hacks/src/romvecs-insert.S @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 8d9298e0823a
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
467
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 .text
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 .code 32
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 .globl _entry
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 _entry: adr r0, vectors
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 ldmia r0, {r1-r7}
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 mov r0, #0x800000
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 stmia r0, {r1-r7}
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 ldr pc, jumpaddr
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 vectors:
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 .word 0x4000
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13 .word 0x4004
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14 .word 0x4008
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 .word 0x400C
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 .word 0x4010
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17 .word 0x4014
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18 .word 0x4018
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 jumpaddr:
3285960cc1b9 romvecs-patch: experimental insert code written
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 .word 0x4058