FreeCalypso > hg > fc-magnetite
annotate cfg-headers/gprs/swconfig.cfg @ 516:1ed9de6c90bd
src/g23m-gsm/sms/sms_for.c: bogus malloc removed
The new error handling code that was not present in TCS211 blob version
contains a malloc call that is bogus for 3 reasons:
1) The memory allocation in question is not needed in the first place;
2) libc malloc is used instead of one of the firmware's proper ways;
3) The memory allocation is made inside a function and then never freed,
i.e., a memory leak.
This bug was caught in gcc-built FreeCalypso fw projects (Citrine
and Selenite) because our gcc environment does not allow any use of
libc malloc (any reference to malloc produces a link failure),
but this code from TCS3.2 is wrong even for Magnetite: if this code
path is executed repeatedly over a long time, the many small allocations
made by this malloc call without a subsequent free will eventually
exhaust the malloc heap provided by the TMS470 environment, malloc will
start returning NULL, and the bogus code will treat it as an error.
Because the memory allocation in question is not needed at all,
the fix entails simply removing it.
| author | Mychaela Falconia <falcon@freecalypso.org> |
|---|---|
| date | Sun, 22 Jul 2018 06:04:49 +0000 |
| parents | fd8227e3047d |
| children |
| rev | line source |
|---|---|
|
5
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
1 #ifndef __SWCONFIG_CFG__ |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
2 #define __SWCONFIG_CFG__ |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
3 #define ALR 1 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
4 #define BT 0 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
5 #define DP 0 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
6 #define DWNLD 1 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
7 #define GSMLITE 0 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
8 #define L1_DYN_DSP_DWNLD 1 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
9 #define LONG_JUMP 3 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
10 #define MOVE_IN_INTERNAL_RAM 1 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
11 #define OP_WCP 0 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
12 #define PMODE 2 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
13 #define RVDATA_INTERNALRAM 0 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
14 #define SRVC 1 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
15 #define TR_BAUD_CONFIG TR_BAUD_115200 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
16 #define WCP_PROF 0 |
|
53c4389afc06
cfg-headers/2091: pdt_2091 config headers
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff
changeset
|
17 #endif /* __SWCONFIG_CFG__ */ |
