annotate cdg211/cdginc/ccdent.cdg @ 516:1ed9de6c90bd

src/g23m-gsm/sms/sms_for.c: bogus malloc removed The new error handling code that was not present in TCS211 blob version contains a malloc call that is bogus for 3 reasons: 1) The memory allocation in question is not needed in the first place; 2) libc malloc is used instead of one of the firmware's proper ways; 3) The memory allocation is made inside a function and then never freed, i.e., a memory leak. This bug was caught in gcc-built FreeCalypso fw projects (Citrine and Selenite) because our gcc environment does not allow any use of libc malloc (any reference to malloc produces a link failure), but this code from TCS3.2 is wrong even for Magnetite: if this code path is executed repeatedly over a long time, the many small allocations made by this malloc call without a subsequent free will eventually exhaust the malloc heap provided by the TMS470 environment, malloc will start returning NULL, and the bogus code will treat it as an error. Because the memory allocation in question is not needed at all, the fix entails simply removing it.
author Mychaela Falconia <falcon@freecalypso.org>
date Sun, 22 Jul 2018 06:04:49 +0000
parents 56abf6cf8a0b
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
4
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
1 /*
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
2 +--------------------------------------------------------------------------+
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
3 | PROJECT : PROTOCOL STACK |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
4 | FILE : ccdent.cdg |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
5 | SOURCE : "__out__\g23m_dfile\msg\rr_com.mdf" |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
6 | LastModified : "2002-11-18" |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
7 | IdAndVersion : "8443.250.02.008" |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
8 | SrcFileTime : "Mon Nov 24 15:49:38 2003" |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
9 | Generated by CCDGEN_2.5.5 on Fri Jun 08 13:59:14 2007 |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
10 | !!DO NOT MODIFY!!DO NOT MODIFY!!DO NOT MODIFY!! |
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
11 +--------------------------------------------------------------------------+
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
12 */
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
13
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
14
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
15 #ifndef CCDENT_CDG
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
16 #define CCDENT_CDG
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
17
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
18
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
19 /* 0*/ { "RR_COM" , CCDENT_RR_COM },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
20 /* 1*/ { "RR" , CCDENT_RR },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
21 /* 2*/ { "MM" , CCDENT_MM },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
22 /* 3*/ { "CC" , CCDENT_CC },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
23 /* 4*/ { "SS" , CCDENT_SS },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
24 /* 5*/ { "SMS" , CCDENT_SMS },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
25 /* 6*/ { "FAC" , CCDENT_FAC },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
26 /* 7*/ { "SAT" , CCDENT_SAT },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
27 /* 8*/ { "T30" , CCDENT_T30 },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
28 /* 9*/ { "GMM" , CCDENT_GMM },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
29 /* 10*/ { "TST" , CCDENT_TST },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
30 /* 11*/ { "GRLC" , CCDENT_GRLC },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
31 /* 12*/ { "GRR" , CCDENT_GRR },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
32 /* 13*/ { "SM" , CCDENT_SM },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
33 /*65535*/ { (char *) NULL , 65535 },
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
34
56abf6cf8a0b cdg211: cdginc/mdf/pdf files from TCS211-20070608
Mychaela Falconia <falcon@freecalypso.org>
parents:
diff changeset
35 #endif